| Summary: | Add support for MediaStream audio track rendering in GPUProcess | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, ryanhaddad, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
youenn fablet
2020-01-13 08:12:18 PST
Created attachment 387530 [details]
Patch
Created attachment 387628 [details]
Patch
Created attachment 387629 [details]
Patch
Comment on attachment 387629 [details] Patch Clearing flags on attachment: 387629 Committed r254505: <https://trac.webkit.org/changeset/254505> All reviewed patches have been landed. Closing bug. Comment on attachment 387629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387629&action=review > Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:39 > +namespace IPC { > +class Connection; > +class DataReference; > +class Decoder; > +} These probably aren't necessary since you include MessageReceiver.h above. (In reply to Eric Carlson from comment #7) > Comment on attachment 387629 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387629&action=review > > > Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:39 > > +namespace IPC { > > +class Connection; > > +class DataReference; > > +class Decoder; > > +} > > These probably aren't necessary since you include MessageReceiver.h above. Filed https://bugs.webkit.org/show_bug.cgi?id=206236 Reverted r254505 for reason: Breaks watchOS/tvOS/Catalyst builds. Committed r254516: <https://trac.webkit.org/changeset/254516> *** Bug 206236 has been marked as a duplicate of this bug. *** Created attachment 387760 [details]
Fixing non MediaStream builds
Comment on attachment 387760 [details] Fixing non MediaStream builds Rejecting attachment 387760 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 387760, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13304664 Created attachment 387767 [details]
Fixing non MediaStream builds
The commit-queue encountered the following flaky tests while processing attachment 387767 [details]: media/track/track-cues-sorted-before-dispatch.html bug 206225 (authors: simon.pena@samsung.com and vcarbune@chromium.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 387767 [details]: http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 387767 [details] Fixing non MediaStream builds Clearing flags on attachment: 387767 Committed r254562: <https://trac.webkit.org/changeset/254562> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 387774 [details]
Patch for landing
|