Bug 206160

Summary: Import the update of img-aspect-ratio.html
Product: WebKit Reporter: cathiechen <cathiechen>
Component: DOMAssignee: cathiechen <cathiechen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, fred.wang, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 201641    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

cathiechen
Reported 2020-01-12 20:42:15 PST
parseInt() of img-aspect-ratio.html has been changed to parseFloat() on WPT, we need to import this update.
Attachments
Patch (10.89 KB, patch)
2020-01-12 20:46 PST, cathiechen 		no flags
DetailsFormatted DiffDiff
Patch (11.08 KB, patch)
2020-01-13 05:45 PST, cathiechen 		no flags
DetailsFormatted DiffDiff
Patch (11.08 KB, patch)
2020-01-13 06:35 PST, cathiechen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
cathiechen
Comment 1 2020-01-12 20:46:34 PST
Created attachment 387501 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2020-01-13 05:17:40 PST
Comment on attachment 387501 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387501&action=review > LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/align.html:3 > +<script src="/resources/testharness.js"></script> Can you please check what's our convention and explain in the changelog why this change happens?
cathiechen
Comment 3 2020-01-13 05:45:59 PST
Created attachment 387517 [details] Patch
cathiechen
Comment 4 2020-01-13 06:35:09 PST
Created attachment 387522 [details] Patch
WebKit Commit Bot
Comment 5 2020-01-13 10:27:55 PST
The commit-queue encountered the following flaky tests while processing attachment 387522 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-01-13 10:28:28 PST
The commit-queue encountered the following flaky tests while processing attachment 387522 [details]: inspector/debugger/breakpoint-scope.html bug 205646 (authors: drousso@apple.com and joepeck@webkit.org) imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html bug 201481 (authors: shvaikalesh@gmail.com and youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2020-01-13 15:34:59 PST
The commit-queue encountered the following flaky tests while processing attachment 387522 [details]: media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html bug 193587 (author: graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2020-01-13 15:35:29 PST
Comment on attachment 387522 [details] Patch Clearing flags on attachment: 387522 Committed r254461: <https://trac.webkit.org/changeset/254461>
WebKit Commit Bot
Comment 9 2020-01-13 15:35:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2020-01-13 15:36:12 PST
<rdar://problem/58547152>
Note You need to log in before you can comment on or make changes to this bug.