Bug 206127

Summary: [GTK][WPE] Many imported/w3c/web-platform-tests/html/ tests failing after r253791
Product: WebKit Reporter: Pablo Saavedra <psaavedra>
Component: Tools / TestsAssignee: Pablo Saavedra <psaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, pnormand, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch
none
patch 2 none

Description Pablo Saavedra 2020-01-10 22:48:19 PST 
The imported/w3c/web-platform-tests/html/ tests were updated the last 2019-12-19 in https://bugs.webkit.org/show_bug.cgi?id=205424 (Resync web-platform-tests/html) tests from upstream)

As result of this, many tests are being listed as unexpected failures for the GTK port

Probably a refresh of the `-expected` files is needed for the GTK port.


List of failed tests:

    imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-vertical-lr.html [ Failure ]
    imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-vertical-rl.html [ Failure ]
    imported/w3c/web-platform-tests/html/browsers/sandboxing/sandbox-parse-noscript.html [ Failure ]
    imported/w3c/web-platform-tests/html/dom/idlharness.https.html [ Failure ]
    imported/w3c/web-platform-tests/html/dom/idlharness.worker.html [ Failure ]
    imported/w3c/web-platform-tests/html/dom/reflection-forms.html [ Failure ]
    imported/w3c/web-platform-tests/html/editing/editing-0/autocapitalization/autocapitalize.html [ Failure ]
    imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets.html [ Failure ]
    imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-generated-content.html [ Failure ]
    imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-sans-fieldset-display.html [ Failure ]
    imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/abspos.html [ Failure ]
    imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/grid.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/media_fragment_seek.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/video_loop_base.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_allow_downloads.sub.tentative.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_block_downloads.sub.tentative.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/resize-during-playback.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/interfaces.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/json-module/valid-content-type.tentative.html [ Failure ]
    imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html [ Failure ]
Comment 1 Pablo Saavedra 2020-01-12 01:47:29 PST 
Created attachment 387462 [details]
patch
Comment 2 Pablo Saavedra 2020-01-12 01:50:15 PST 
Created attachment 387463 [details]
patch
Comment 3 Pablo Saavedra 2020-01-12 06:27:39 PST 
Created attachment 387468 [details]
patch
Comment 4 Pablo Saavedra 2020-01-12 12:10:02 PST 
Created attachment 387485 [details]
patch
Comment 5 Pablo Saavedra 2020-01-13 01:43:17 PST 
The changes only affect to the Gtk and WPE expectations. 

Also executed test in local for Catalina. I detected some unexpected fails but not related with the expectations modified in this patch (not global expectations modified for those tests) so I suppose this was already failing.


Expected to fail, but passed: (2)
  imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/sizes-dynamic-002.html
  imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter.html


Regressions: Unexpected text-only failures (1)
  imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url.html [ Failure ]
Comment 6 WebKit Commit Bot 2020-01-13 20:05:54 PST 
Comment on attachment 387485 [details]
patch

Clearing flags on attachment: 387485

Committed r254486: <https://trac.webkit.org/changeset/254486>
Comment 7 WebKit Commit Bot 2020-01-13 20:05:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-01-13 20:06:15 PST 
<rdar://problem/58555260>
Comment 9 Pablo Saavedra 2020-01-14 03:45:05 PST 
Reopening to attach new patch.
Comment 10 Pablo Saavedra 2020-01-14 03:45:11 PST 
Created attachment 387642 [details]
patch 2
Comment 11 Pablo Saavedra 2020-01-14 03:48:13 PST 
(In reply to Pablo Saavedra from comment #10)
> Created attachment 387642 [details]
> patch 2

Updated some extra expectations related to the update of tests in https://bugs.webkit.org/show_bug.cgi?id=205424.
Comment 12 WebKit Commit Bot 2020-01-14 04:43:05 PST 
The commit-queue encountered the following flaky tests while processing attachment 387642 [details]:

media/track/track-cues-sorted-before-dispatch.html bug 206225 (authors: simon.pena@samsung.com and vcarbune@chromium.org)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2020-01-14 04:43:11 PST 
The commit-queue encountered the following flaky tests while processing attachment 387642 [details]:

media/track/track-in-band-metadata-display-order.html bug 206226 (author: jer.noble@apple.com)
The commit-queue is continuing to process your patch.
Comment 14 WebKit Commit Bot 2020-01-14 05:11:32 PST 
The commit-queue encountered the following flaky tests while processing attachment 387642 [details]:

media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html bug 193587 (author: graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 15 WebKit Commit Bot 2020-01-14 05:12:28 PST 
Comment on attachment 387642 [details]
patch 2

Clearing flags on attachment: 387642

Committed r254504: <https://trac.webkit.org/changeset/254504>
Comment 16 WebKit Commit Bot 2020-01-14 05:12:30 PST 
All reviewed patches have been landed.  Closing bug.