Bug 206092

Summary:	Clarify WebKit Owners policy
Product:	WebKit	Reporter:	Don Olmstead <don.olmstead>
Component:	WebKit2	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	achristensen, aestes, andersca, ap, bdakin, beidson, benjamin, cdumez, darin, enrica, ggaren, Hironori.Fujii, hyatt, koivisto, mitz, mjs, rniwa, sam, simon.fraser, thorton, youennf
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Don Olmstead 2020-01-10 14:31:44 PST

Currently the WebKit/Owners file states the following

All patches to WebKit2 must be reviewed and/or authored by one of the following:

The policy should be more explicit on what parts of WebKit require an Owner to review so other WebKit reviewers know which patches they are and are not allowed to review within this part of the code.

Comment 1 Don Olmstead 2020-01-10 14:35:30 PST

My understanding is that a reviewer should for sure be involved in anything involving the shared C API and IPC code but I don't think there's been an official stance on this.

Comment 2 Chris Dumez 2020-01-10 14:43:40 PST

(In reply to Don Olmstead from comment #1)
> My understanding is that a reviewer should for sure be involved in anything
> involving the shared C API and IPC code but I don't think there's been an
> official stance on this.

My understanding is that any cross-platform WebKit2 code needs WK2 Owner approval. That would include cross-platform IPC and shared C API. I personally think that an IPC that is specific to your port does not need owner approval, similarly to any code that is specific to your port.

Comment 3 Alex Christensen 2020-01-10 15:08:25 PST

The policy applies to any code change in the Source/WebKit directory.  If it is code that is only compiled for your port, then you're probably ok, but if you're exposing something in your API that isn't exposed in the owners' APIs then you should definitely consult an owner because we may intend to do substantial changes that may break your newly-exposed API.

Comment 4 Fujii Hironori 2020-01-10 21:16:22 PST

[webkit-dev] OWNERS policy
https://lists.webkit.org/pipermail/webkit-dev/2018-February/029884.html