Bug 206084

Summary: Add modulemap for WebKit Private APIs (take 2)
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: NEW ---    
Severity: Normal CC: andersca, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch thorton: review+

Description Dean Jackson 2020-01-10 13:09:34 PST 
Add Swift modulemap for WebKit Private APIs (take 2)
Comment 1 Radar WebKit Bug Importer 2020-01-10 13:10:19 PST 
<rdar://problem/58488356>
Comment 2 Dean Jackson 2020-01-10 13:14:03 PST 
Created attachment 387368 [details]
Patch
Comment 3 Dean Jackson 2020-01-10 13:48:52 PST 
Created attachment 387371 [details]
Patch
Comment 4 Dean Jackson 2020-01-10 14:57:16 PST 
Created attachment 387378 [details]
Patch
Comment 5 Anders Carlsson 2020-01-10 18:09:47 PST 
Looks like the builds are broken.
Comment 6 Dean Jackson 2020-01-11 10:06:20 PST 
Created attachment 387435 [details]
Patch
Comment 7 Dean Jackson 2020-01-11 11:04:51 PST 
Created attachment 387437 [details]
Patch
Comment 8 Dean Jackson 2020-01-11 11:51:10 PST 
Created attachment 387439 [details]
Patch
Comment 9 Tim Horton 2020-01-14 15:08:47 PST 
Comment on attachment 387439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387439&action=review

> Source/WebKit/Shared/API/Cocoa/WebKitPrivate.h:31
> +#import <WebKit/DOMHTMLMediaElement.h>

I wooooonder if we should not include the WebKitLegacy headers, and tuck them in a TAPI -extra-private-header (aka the way to lie to TAPI). Probably the correct answer is "no" but it feels so much less dirty :(
Comment 10 Dean Jackson 2020-01-17 16:58:03 PST 
(In reply to Anders Carlsson from comment #5)
> Looks like the builds are broken.

👍
Comment 11 Dean Jackson 2020-01-17 16:58:59 PST 
(In reply to Tim Horton from comment #9)
> Comment on attachment 387439 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387439&action=review
> 
> > Source/WebKit/Shared/API/Cocoa/WebKitPrivate.h:31
> > +#import <WebKit/DOMHTMLMediaElement.h>
> 
> I wooooonder if we should not include the WebKitLegacy headers, and tuck
> them in a TAPI -extra-private-header (aka the way to lie to TAPI). Probably
> the correct answer is "no" but it feels so much less dirty :(

I bet that if we do that, some random project will fail to compile, like before. We'd have to search for all the projects that are trying to include those headers wouldn't we?