Bug 206080

Summary:

Different statements are cached to same entry in SQLiteIDBBackingStore

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

New Bugs

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

achristensen, alecflett, beidson, cdumez, ews-watchlist, jsbell, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sihui Liu 2020-01-10 12:03:16 PST

...

Comment 1 Sihui Liu 2020-01-10 12:05:30 PST

Created attachment 387360 [details]
Patch

Comment 2 Sihui Liu 2020-01-13 09:03:23 PST

ping for review...

Comment 3 youenn fablet 2020-01-13 09:28:45 PST

Comment on attachment 387360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387360&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1627
> +    auto* sql = cachedStatement(SQL::DeleteObjectStoreIndexRecordWithKey, "DELETE FROM IndexRecords WHERE objectStoreID = ? AND objectStoreRecordID = ? AND key = CAST(? AS TEXT);"_s);

I guess this should be observable, can we write a test?