| Summary: | Introduce an abstract SampleBufferDisplayLayer | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, jlewis3, peng.liu6, philipj, sergio, webkit-bug-importer, youennf | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | 206060 | ||||||||||||||||||
| Bug Blocks: | 206286 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
youenn fablet
2020-01-10 07:54:57 PST
Created attachment 387340 [details]
Patch
Created attachment 387343 [details]
Patch
Created attachment 387346 [details]
Patch
Comment on attachment 387346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387346&action=review > Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:118 > + callOnMainThread([protectedSelf = RetainPtr<WebAVSampleBufferStatusChangeListener>(self), layer = WTFMove(layer), status = WTFMove(status)] { Nit: layer and status aren't used in the lambda. > Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:129 > + callOnMainThread([protectedSelf = RetainPtr<WebAVSampleBufferStatusChangeListener>(self), layer = WTFMove(layer), status = WTFMove(status)] { Ditto Created attachment 387518 [details]
Patch
Comment on attachment 387518 [details] Patch Rejecting attachment 387518 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 387518, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file. Full output: https://webkit-queues.webkit.org/results/13303942 Created attachment 387778 [details]
Patch for landing
Comment on attachment 387778 [details] Patch for landing Rejecting attachment 387778 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 387778, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file. Full output: https://webkit-queues.webkit.org/results/13304732 Created attachment 387781 [details]
Patch for landing
Comment on attachment 387781 [details] Patch for landing Clearing flags on attachment: 387781 Committed r254564: <https://trac.webkit.org/changeset/254564> All reviewed patches have been landed. Closing bug. Reverted r254564 for reason: This caused internal test crashes. Committed r254779: <https://trac.webkit.org/changeset/254779> Created attachment 388211 [details]
Patch for landing
Comment on attachment 388211 [details] Patch for landing Clearing flags on attachment: 388211 Committed r254813: <https://trac.webkit.org/changeset/254813> All reviewed patches have been landed. Closing bug. |