Bug 206039

Summary: Clean up -[WKWebView _initializeWithConfiguration:]
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch none

Description Simon Fraser (smfr) 2020-01-09 15:06:30 PST 
Clean up -[WKWebView _initializeWithConfiguration:]
Comment 1 Simon Fraser (smfr) 2020-01-09 15:07:57 PST 
Created attachment 387279 [details]
Patch
Comment 2 Tim Horton 2020-01-09 15:19:47 PST 
Comment on attachment 387279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387279&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:170
> +static const BOOL defaultAllowsViewportShrinkToFit = YES;

Shouldn't these be in some WebPreferences* file?
Comment 3 Simon Fraser (smfr) 2020-01-09 15:57:19 PST 
Created attachment 387285 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-01-10 11:52:10 PST 
https://trac.webkit.org/changeset/254315/webkit
Comment 5 Radar WebKit Bug Importer 2020-01-10 11:53:18 PST 
<rdar://problem/58486170>