| Summary: | Remove AGXCompilerService access from the WebContent sandbox | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, pvollan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Brent Fulgham
2020-01-09 11:44:12 PST
Created attachment 387251 [details]
Patch
Should we also add a test case for this in fast/sandbox/ios/sandbox-mach-lookup.html? (In reply to Per Arne Vollan from comment #3) > Should we also add a test case for this in > fast/sandbox/ios/sandbox-mach-lookup.html? Since this is hardware specific, will we have too many test failures? Is there a way to skip on specific hardware? I think we only support version and platform (not 2017 iPad versus 2018 iPad, for example). (In reply to Brent Fulgham from comment #4) > (In reply to Per Arne Vollan from comment #3) > > Should we also add a test case for this in > > fast/sandbox/ios/sandbox-mach-lookup.html? > > Since this is hardware specific, will we have too many test failures? > > Is there a way to skip on specific hardware? I think we only support version > and platform (not 2017 iPad versus 2018 iPad, for example). You're right, I don't think there is a way to skip specific hardware. Comment on attachment 387251 [details]
Patch
Great! R=me.
Comment on attachment 387251 [details] Patch Clearing flags on attachment: 387251 Committed r254306: <https://trac.webkit.org/changeset/254306> All reviewed patches have been landed. Closing bug. |