| Summary: | Fix various non-unified build issues introduced since r253538 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||||
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, cgarcia, clopez, dbates, dino, eric.carlson, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, keith_miller, mark.lam, msaboff, pnormand, saam, tzagallo, webkit-bug-importer, youennf, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Adrian Perez
2020-01-09 03:52:09 PST
Created attachment 387225 [details]
Patch
Comment on attachment 387225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387225&action=review > Source/JavaScriptCore/ChangeLog:3 > + [GTK][WPE] Fix various non-unified build issues introduced since r253538 Why is this marked GTK and WPE specific? (In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 387225 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387225&action=review > > > Source/JavaScriptCore/ChangeLog:3 > > + [GTK][WPE] Fix various non-unified build issues introduced since r253538 > > Why is this marked GTK and WPE specific? Right… no reason whatsoever. Let's remove the tags. Comment on attachment 387225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387225&action=review > Source/WebCore/page/PageConfiguration.h:34 > +#include <wtf/text/WTFString.h> Would <wtf/Forward.h> work here? (In reply to youenn fablet from comment #4) > Comment on attachment 387225 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387225&action=review > > > Source/WebCore/page/PageConfiguration.h:34 > > +#include <wtf/text/WTFString.h> > > Would <wtf/Forward.h> work here? I'll give that a try, thanks for the suggestion. (In reply to Adrian Perez from comment #5) > (In reply to youenn fablet from comment #4) > > Comment on attachment 387225 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=387225&action=review > > > > > Source/WebCore/page/PageConfiguration.h:34 > > > +#include <wtf/text/WTFString.h> > > > > Would <wtf/Forward.h> work here? > > I'll give that a try, thanks for the suggestion. Yes, using <wtf/Forward.h> instead of <wtf/text/WTFString.h> worked. I'll land a version of the patch with this change applied and the bug title adjusted as per Carlos' suggestion. As there are mentions to files NarrowingNumberPredictionFuzzerAgent.cpp and NarrowingNumberPredictionFuzzerAgent.cpp which contain the string “fuzzer” in them, the style checker complains, so I will land the patch manually after checking that the EWS bots build with the patch fine :) Created attachment 387269 [details]
Patch for landing
Committed r254327: <https://trac.webkit.org/changeset/254327> |