Bug 205980

Summary:

Set the title for images so it will be correctly displayed in UIContextMenus

Product:

WebKit

Reporter:

Megan Gardner <megan_gardner>

Component:

New Bugs

Assignee:

Megan Gardner <megan_gardner>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Megan Gardner 2020-01-08 18:15:41 PST

Set the title for images so it will be correctly displayed in UIContextMenus

Comment 1 Megan Gardner 2020-01-08 18:16:51 PST

Created attachment 387175 [details]
Patch

Comment 2 Megan Gardner 2020-01-08 18:17:46 PST

<rdar://problem/57701988>

Comment 3 Tim Horton 2020-01-08 23:02:59 PST

Comment on attachment 387175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387175&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8483
> +                return [UIMenu menuWithTitle:[elementInfo title] children:actions];

I still maintain you should use positionInfo here, not the API wrapper :)

Comment 4 Megan Gardner 2020-01-09 11:30:44 PST

Created attachment 387248 [details]
Patch for landing

Comment 5 WebKit Commit Bot 2020-01-09 13:10:24 PST

Comment on attachment 387248 [details]
Patch for landing

Clearing flags on attachment: 387248

Committed r254292: <https://trac.webkit.org/changeset/254292>

Comment 6 WebKit Commit Bot 2020-01-09 13:10:26 PST

All reviewed patches have been landed.  Closing bug.