Bug 205965

Summary: [PlayStation] Enable WebKit
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebKit2Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, Basuke.Suzuki, bfulgham, commit-queue, ews-watchlist, gyuyoung.kim, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205964, 206186, 206198, 206243, 206247, 206267, 206320, 206323, 206324    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
WIP Patch
none
Patch
ross.kirsling: review+
Patch none

Description Don Olmstead 2020-01-08 15:49:03 PST 
Enable WebKit for the PlayStation port
Comment 1 Don Olmstead 2020-01-14 13:43:03 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-01-14 13:44:20 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2020-01-14 13:56:09 PST Comment hidden (obsolete)
Comment 4 Don Olmstead 2020-01-16 14:02:07 PST 
Created attachment 387954 [details]
Patch
Comment 5 Ross Kirsling 2020-01-16 14:36:42 PST 
Comment on attachment 387954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387954&action=review

r=me with nits

> Source/WebKit/Platform/unix/ModuleUnix.cpp:40
> +void* Module::platformFunctionPointer(const char* functionName) const

Seems like we should recheck the newly-added files for unused param names like this one.

> Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp:43
> +    return nullptr; // static_cast<PageClientImpl&>(pageClient()).viewBackend();

The commented-out code in this file seems like it should be removed.
Comment 6 Don Olmstead 2020-01-16 14:47:43 PST 
Created attachment 387963 [details]
Patch

Fix the nits
Comment 7 WebKit Commit Bot 2020-01-16 15:15:04 PST 
Comment on attachment 387963 [details]
Patch

Clearing flags on attachment: 387963

Committed r254713: <https://trac.webkit.org/changeset/254713>
Comment 8 WebKit Commit Bot 2020-01-16 15:15:06 PST 
All reviewed patches have been landed.  Closing bug.