Bug 205957

Summary: We should pass in -parallelizeTargets for the JavaScriptCore xcodebuild
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: REOPENED    
Severity: Normal CC: ap, benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, krollin, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206011
Attachments:
Description Flags
patch none

Saam Barati
Reported 2020-01-08 14:28:30 PST
...
Attachments
patch (10.49 KB, patch)
2020-01-08 14:59 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-01-08 14:59:27 PST
Created attachment 387144 [details] patch
Keith Miller
Comment 2 2020-01-08 15:09:24 PST
Comment on attachment 387144 [details] patch r=me.
WebKit Commit Bot
Comment 3 2020-01-08 16:13:33 PST
Comment on attachment 387144 [details] patch Clearing flags on attachment: 387144 Committed r254234: <https://trac.webkit.org/changeset/254234>
WebKit Commit Bot
Comment 4 2020-01-08 16:13:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-01-08 16:14:14 PST
<rdar://problem/58425712>
Alexey Proskuryakov
Comment 6 2020-01-08 19:16:49 PST
Why only JavaScriptCore though?
Keith Miller
Comment 7 2020-01-08 19:18:46 PST
(In reply to Alexey Proskuryakov from comment #6) > Why only JavaScriptCore though? IIUC, the other projects' targets don't have their dependences correctly configured to work with parallel builds.
Saam Barati
Comment 8 2020-01-08 19:21:15 PST
(In reply to Alexey Proskuryakov from comment #6) > Why only JavaScriptCore though? JavaScriptCore gets a lot of benefit since we have many test binaries we build after it. We should enable this for others too, eventually. Just need to go through to see which build targets would benefit
Saam Barati
Comment 9 2020-01-08 19:24:44 PST
I forgot to mention in the changelog, but this saves 20 seconds of build time on my MBP with 6 cores
Saam Barati
Comment 10 2020-01-08 22:43:51 PST
Comment on attachment 387144 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=387144&action=review > Source/JavaScriptCore/ChangeLog:4 > + build-jsc should invoke make instead of calling xcodebuild directly > + https://bugs.webkit.org/show_bug.cgi?id=205960 oops, this was the wrong bug :( Sorry
Alexey Proskuryakov
Comment 11 2020-01-09 08:50:44 PST
Rolling back in bug 206011, because this broke production builds. > IIUC, the other projects' targets don't have their dependences correctly configured to work with parallel builds. In my testing, JavaScriptCore was the only one that wasn't correctly configured. Everything else built fine - although that could be accidental of course. > Just need to go through to see which build targets would benefit All of WebKit builds 80 seconds faster on an 18-core iMac Pro with this.
Saam Barati
Comment 12 2020-01-09 16:41:24 PST
(In reply to Alexey Proskuryakov from comment #11) > Rolling back in bug 206011, because this broke production builds. > > > IIUC, the other projects' targets don't have their dependences correctly configured to work with parallel builds. > > In my testing, JavaScriptCore was the only one that wasn't correctly > configured. Everything else built fine - although that could be accidental > of course. > > > Just need to go through to see which build targets would benefit > > All of WebKit builds 80 seconds faster on an 18-core iMac Pro with this. Do you know if all of the benefit is inside JavaScriptCore?
Saam Barati
Comment 13 2020-01-09 16:43:11 PST
This was rolled out because it broke some apple internal build infrastructure
Saam Barati
Comment 14 2020-01-09 16:48:42 PST
(In reply to Saam Barati from comment #13) > This was rolled out because it broke some apple internal build infrastructure It was rolled out in: https://trac.webkit.org/changeset/254262
Alexey Proskuryakov
Comment 15 2020-01-09 17:45:37 PST
> Do you know if all of the benefit is inside JavaScriptCore? I do not know for sure, but my expectation is that it's in other projects too.
Note You need to log in before you can comment on or make changes to this bug.