Bug 205950

Summary: WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206018
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-01-08 12:14:37 PST
WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared. This occurs on both iOS and macOS. <rdar://problem/50987831>
Attachments
Patch v1 (5.61 KB, patch)
2020-01-08 15:05 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-01-08 15:05:56 PST
Created attachment 387145 [details] Patch v1
Joseph Pecoraro
Comment 2 2020-01-08 17:10:55 PST
Comment on attachment 387145 [details] Patch v1 Nice! r=me
WebKit Commit Bot
Comment 3 2020-01-09 03:47:38 PST
Comment on attachment 387145 [details] Patch v1 Clearing flags on attachment: 387145 Committed r254254: <https://trac.webkit.org/changeset/254254>
WebKit Commit Bot
Comment 4 2020-01-09 03:47:40 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2020-01-09 10:36:21 PST
Comment on attachment 387145 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=387145&action=review > Tools/WebKitTestRunner/ios/mainIOS.mm:73 > UIApplicationMain(argc, (char**)argv, @"WebKitTestRunnerApp", @"WebKitTestRunnerApp"); No need for an autorelease pool around this? > Tools/WebKitTestRunner/mac/main.mm:68 > + WTR::TestController controller(argc, argv); No need for an autorelease pool around this?
Darin Adler
Comment 6 2020-01-09 10:38:00 PST
Comment on attachment 387145 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=387145&action=review >> Tools/WebKitTestRunner/ios/mainIOS.mm:73 >> UIApplicationMain(argc, (char**)argv, @"WebKitTestRunnerApp", @"WebKitTestRunnerApp"); > > No need for an autorelease pool around this? I guess it would never be drained, so it would be bad if it was needed, but I’m still wonder if we might start getting diagnostics about things being autoreleased without a pool. Although those would be leaks, I guess. >> Tools/WebKitTestRunner/mac/main.mm:68 >> + WTR::TestController controller(argc, argv); > > No need for an autorelease pool around this? Same.
David Kilzer (:ddkilzer)
Comment 7 2020-01-09 10:45:12 PST
Comment on attachment 387145 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=387145&action=review >>> Tools/WebKitTestRunner/ios/mainIOS.mm:73 >>> UIApplicationMain(argc, (char**)argv, @"WebKitTestRunnerApp", @"WebKitTestRunnerApp"); >> >> No need for an autorelease pool around this? > > I guess it would never be drained, so it would be bad if it was needed, but I’m still wonder if we might start getting diagnostics about things being autoreleased without a pool. Although those would be leaks, I guess. Any autoreleasePool "leaks" inside UIApplicationMain() need to be handled in a localized manner. As you note, adding an @autoreleasepool block around UIApplicationMain() would never be drained. >>> Tools/WebKitTestRunner/mac/main.mm:68 >>> + WTR::TestController controller(argc, argv); >> >> No need for an autorelease pool around this? > > Same. Same, but there are some additional autoreleasePool "leaks" under WTR::TestController::TestController() during initialization, so a follow-up patch is warranted.
David Kilzer (:ddkilzer)
Comment 8 2020-01-09 11:35:12 PST
Additional improvements to autoreleasePool leaks tracked in Bug 206018.
Note You need to log in before you can comment on or make changes to this bug.