| Summary: | TypeProfiler.h: Multiplication result converted to larger type | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
| Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 387131 [details]
Patch
Comment on attachment 387131 [details] Patch Clearing flags on attachment: 387131 Committed r254224: <https://trac.webkit.org/changeset/254224> All reviewed patches have been landed. Closing bug. |
Summary: TypeProfiler.h: Multiplication result converted to larger type: Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'. unsigned hash() const { unsigned hash = m_sourceID + m_divot * m_searchDescriptor; Multiplication result may overflow 'unsigned int' before it is converted to 'long'. return hash; } fix: fix cast m_sourceID to unsigned or cast the whole result to unsigned.