| Summary: | Reformat FrameLoader logging | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||
| Component: | WebKit Misc. | Assignee: | Keith Rollin <krollin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, dbates, ews-watchlist, japhet, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=205679 | ||||||
| Attachments: |
|
||||||
Created attachment 387030 [details]
Patch
Comment on attachment 387030 [details]
Patch
LGTM. r=me
Comment on attachment 387030 [details] Patch Clearing flags on attachment: 387030 Committed r254179: <https://trac.webkit.org/changeset/254179> All reviewed patches have been landed. Closing bug. |
Update the format used by FrameLoader in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values> So, for example: 0x4aa2df000 - FrameLoader::allAllLoaders: Clearing provisional document loader (frame = 0x4a8ad3550, main = 0 m_provisionalDocumentLoader=0x0) becomes: 0x465fb61a0 - [frame=0x465c98a20, main=0] FrameLoader::stopAllLoaders: Clearing provisional document loader (m_provisionalDocumentLoader=0x0)