| Summary: | [JSC] Remove vm accessor in JSVirtualMachine to reduce binary size | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 205877 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-01-07 12:14:43 PST
Let's do it right now since it is the largest. Created attachment 387019 [details]
Patch
Comment on attachment 387019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387019&action=review > Source/JavaScriptCore/API/JSVirtualMachine.mm:301 > +- (JSContextGroupRef)JSContextGroupRef This style is following `JSContext JSContextRef` accessor. Comment on attachment 387019 [details]
Patch
Nice. r=me if bots are green. Please also run testapi locally to make sure there are no bad surprises (not expecting any).
(In reply to Mark Lam from comment #4) > Comment on attachment 387019 [details] > Patch > > Nice. r=me if bots are green. Please also run testapi locally to make sure > there are no bad surprises (not expecting any). OK, ensured locally. Committed r254152: <https://trac.webkit.org/changeset/254152> |