Bug 205679

Summary: Reformat ProcessThrottler logging
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205680
https://bugs.webkit.org/show_bug.cgi?id=205683
https://bugs.webkit.org/show_bug.cgi?id=205691
https://bugs.webkit.org/show_bug.cgi?id=205705
https://bugs.webkit.org/show_bug.cgi?id=205869
https://bugs.webkit.org/show_bug.cgi?id=205882
https://bugs.webkit.org/show_bug.cgi?id=205884
https://bugs.webkit.org/show_bug.cgi?id=205984
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2020-01-01 20:13:13 PST
Update the format used by ProcessThrottler in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values> So, for example: [PID: 0] 0x1145ce5e8 - ProcessThrottler::invalidateAllActivities() BEGIN becomes: 0x1145ce5e8 - [PID: 0] ProcessThrottler::invalidateAllActivities: BEGIN
Attachments
Patch (10.90 KB, patch)
2020-01-01 20:15 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-01 20:13:23 PST
<rdar://problem/58265958>
Keith Rollin
Comment 2 2020-01-01 20:15:31 PST
Created attachment 386594 [details] Patch
Alex Christensen
Comment 3 2020-01-02 10:53:13 PST
Comment on attachment 386594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386594&action=review > Source/WebKit/UIProcess/ProcessThrottler.h:86 > + PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG("invalidate: Ending %{public}s activity / '%{public}s'", Alternatively you could move these implementations to the cpp file and not have new macros named PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG
Keith Rollin
Comment 4 2020-01-02 12:38:40 PST
(In reply to Alex Christensen from comment #3) > Alternatively you could move these implementations to the cpp file and not > have new macros named PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG Regardless of where the implementation is, I'd still have PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG, since the point of that macro is to identify that the method is from ProcessThrottler::Activity.
WebKit Commit Bot
Comment 5 2020-01-02 13:24:08 PST
The commit-queue encountered the following flaky tests while processing attachment 386594 [details]: highlight/highlight-world-leak.html bug 205643 (author: megan_gardner@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-01-02 13:25:02 PST
Comment on attachment 386594 [details] Patch Clearing flags on attachment: 386594 Committed r253980: <https://trac.webkit.org/changeset/253980>
WebKit Commit Bot
Comment 7 2020-01-02 13:25:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.