Bug 205514

Summary: ANGLE: Fix WebGL conformance test framebuffer-object-attachment.html
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, justin_fan, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948    
Attachments:
Description Flags
ANGLE: Fix WebGL conformance test framebuffer-object-attachment.html
none
Rebaseline layout tests
none
Remove expectation file for ios simulator
none
Remove more obsolete expectations files none

James Darpinian
Reported 2019-12-20 12:06:53 PST
ANGLE: Fix WebGL conformance test framebuffer-object-attachment.html
Attachments
ANGLE: Fix WebGL conformance test framebuffer-object-attachment.html (6.43 KB, patch)
2019-12-20 12:07 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Rebaseline layout tests (51.67 KB, patch)
2019-12-20 17:08 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Remove expectation file for ios simulator (92.87 KB, patch)
2019-12-26 14:37 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Remove more obsolete expectations files (211.40 KB, patch)
2019-12-26 16:09 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2019-12-20 12:07:27 PST
Created attachment 386236 [details] ANGLE: Fix WebGL conformance test framebuffer-object-attachment.html
Kenneth Russell
Comment 2 2019-12-20 16:16:02 PST
Great work James! Would you consider expanding the ChangeLog to say that this largely removes old incorrect validation code, and relies on ANGLE's implementation of depth-texture support across all devices?
James Darpinian
Comment 3 2019-12-20 17:08:52 PST
Created attachment 386281 [details] Rebaseline layout tests
Kenneth Russell
Comment 4 2019-12-23 12:31:38 PST
I bet James would like this CQ'd. Don't worry about the Changelog update I requested. Thanks!
James Darpinian
Comment 5 2019-12-23 16:11:38 PST
It looks like some layout tests are still failing after rebaselining, so I'll fix that when I get back on Thursday.
James Darpinian
Comment 6 2019-12-26 14:37:39 PST
Created attachment 386422 [details] Remove expectation file for ios simulator
James Darpinian
Comment 7 2019-12-26 16:09:19 PST
Created attachment 386425 [details] Remove more obsolete expectations files
James Darpinian
Comment 8 2019-12-26 17:29:16 PST
Layout tests are fixed now, so this should be ready to commit. I updated the changelog to say that this is relying on ANGLE for DEPTH_STENCIL_ATTACHMENT support. The validation code is still there though, I just fixed a couple of places where it was wrong.
WebKit Commit Bot
Comment 9 2019-12-27 00:49:46 PST
Comment on attachment 386425 [details] Remove more obsolete expectations files Clearing flags on attachment: 386425 Committed r253918: <https://trac.webkit.org/changeset/253918>
WebKit Commit Bot
Comment 10 2019-12-27 00:49:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-12-27 00:50:22 PST
<rdar://problem/58214667>
Note You need to log in before you can comment on or make changes to this bug.