Bug 205122

Summary: Python 3: Add support in webkitpy.performance_tests
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, glenn, rniwa, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184986
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-12-11 09:50:58 PST
Make webkitpy.performance_tests Python 3 compatible.
Attachments
Patch (14.53 KB, patch)
2019-12-11 09:53 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.64 KB, patch)
2019-12-11 13:01 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-12-11 09:53:00 PST
Created attachment 385404 [details] Patch
Stephanie Lewis
Comment 2 2019-12-11 12:43:19 PST
Comment on attachment 385404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385404&action=review > Tools/Scripts/webkitpy/performance_tests/perftest.py:171 > + _log.info('median= {} {}, stdev= {} {}, min= {} {}, max= {} {}'.format( When there that many {} I prefer keywords. Makes it easier to read
Jonathan Bedard
Comment 3 2019-12-11 12:59:55 PST
Comment on attachment 385404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385404&action=review >> Tools/Scripts/webkitpy/performance_tests/perftest.py:171 >> + _log.info('median= {} {}, stdev= {} {}, min= {} {}, max= {} {}'.format( > > When there that many {} I prefer keywords. Makes it easier to read Good idea, makes this much more reasonable.
Jonathan Bedard
Comment 4 2019-12-11 13:01:16 PST
Created attachment 385426 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-12-11 13:46:03 PST
Comment on attachment 385426 [details] Patch for landing Clearing flags on attachment: 385426 Committed r253392: <https://trac.webkit.org/changeset/253392>
WebKit Commit Bot
Comment 6 2019-12-11 13:46:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-11 13:47:18 PST
<rdar://problem/57851823>
Note You need to log in before you can comment on or make changes to this bug.