Bug 204793

Summary: Mark some WPT test folders as DumpJSConsoleLogInStdErr
Product: WebKit Reporter: youenn fablet <youennf>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric.carlson, ews-watchlist, Hironori.Fujii, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=256632
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2019-12-03 06:16:50 PST
Mark some WPT test folders as DumpJSConsoleLogInStdErr
Attachments
Patch (352.06 KB, patch)
2019-12-03 07:59 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (387.16 KB, patch)
2019-12-06 07:56 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (391.29 KB, patch)
2019-12-09 01:57 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-12-03 07:59:40 PST
Created attachment 384713 [details] Patch
Fujii Hironori
Comment 2 2019-12-04 00:16:57 PST
Comment on attachment 384713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384713&action=review > Tools/ChangeLog:9 > + This is easier done there instead of TestExpectations as TestExpectations can be overriden in more specific expectations. DumpJSConsoleLogInStdErr expectation is considered a bad idea by some developers. (Bug 194586 Comment 3) And, I removed DumpJSConsoleLogInStdErr expectations from non-imported tests in Bug 194586. Can you remove DumpJSConsoleLogInStdErr expectation entirely? > Tools/DumpRenderTree/TestOptions.cpp:47 > + return path.contains(substring); // Case-insensitive. The comment mismathces the implementation. Case-insensitive → Case-sensitive Tools/WebKitTestRunner/TestOptions.cpp also should be fixed.
youenn fablet
Comment 3 2019-12-06 07:56:33 PST
Created attachment 385013 [details] Patch
youenn fablet
Comment 4 2019-12-09 01:57:06 PST
Created attachment 385139 [details] Patch
youenn fablet
Comment 5 2019-12-10 09:58:45 PST
> Can you remove DumpJSConsoleLogInStdErr expectation entirely? I'd like to skip all stderr from all WPT but there is not consensus yet on that. Note that having DumpJS as a TestExpectation adds some flexibility.
WebKit Commit Bot
Comment 6 2019-12-10 10:51:17 PST
Comment on attachment 385139 [details] Patch Clearing flags on attachment: 385139 Committed r253331: <https://trac.webkit.org/changeset/253331>
WebKit Commit Bot
Comment 7 2019-12-10 10:51:19 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-12-10 10:52:57 PST
<rdar://problem/57799760>
Note You need to log in before you can comment on or make changes to this bug.