Bug 204593

Summary: Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad)
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, koivisto, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: Safari 12   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 203982    
Bug Blocks:    
Attachments:
Description Flags
Removes the code none

Ryosuke Niwa
Reported 2019-11-25 14:14:14 PST
After https://trac.webkit.org/r252761, fragment scrolling doesn't depend on style resolution. Consequently, there is no need for Document::needsStyleRecalc() to return true even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets.
Attachments
Removes the code (1.61 KB, patch)
2019-11-25 14:17 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-11-25 14:17:28 PST
Created attachment 384317 [details] Removes the code
Ryosuke Niwa
Comment 2 2019-11-26 01:53:09 PST
Comment on attachment 384317 [details] Removes the code Nice! Let’s land this.
WebKit Commit Bot
Comment 3 2019-11-26 02:37:50 PST
Comment on attachment 384317 [details] Removes the code Clearing flags on attachment: 384317 Committed r252881: <https://trac.webkit.org/changeset/252881>
WebKit Commit Bot
Comment 4 2019-11-26 02:37:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-11-26 02:38:21 PST
<rdar://problem/57487005>
Note You need to log in before you can comment on or make changes to this bug.