Bug 204546

Summary: Perform microtask checkpoint after each task as spec'ed
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, esprehn+autocc, ews-watchlist, joepeck, kangil.han, keith_miller, sam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=163845
Bug Depends on:    
Bug Blocks: 204042    
Attachments:
Description Flags
Patch
cdumez: review+
Archive of layout-test-results from ews213 for win-future none

Ryosuke Niwa
Reported 2019-11-22 21:59:09 PST
Implement the processing model of the HTML5 event loop to perform a microtask checkpoint after performing tasks's steps: https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-processing-model
Attachments
Patch (16.42 KB, patch)
2019-11-23 00:20 PST, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews213 for win-future (14.47 MB, application/zip)
2019-11-23 02:09 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-22 21:59:37 PST
<rdar://problem/57449333>
Ryosuke Niwa
Comment 2 2019-11-23 00:20:40 PST
Created attachment 384232 [details] Patch
EWS Watchlist
Comment 3 2019-11-23 02:09:14 PST
Comment on attachment 384232 [details] Patch Attachment 384232 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13274794 New failing tests: svg/as-image/svg-nested.html
EWS Watchlist
Comment 4 2019-11-23 02:09:17 PST
Created attachment 384235 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Ryosuke Niwa
Comment 5 2019-12-03 15:30:07 PST
Comment on attachment 384232 [details] Patch Ping reviewers.
Chris Dumez
Comment 6 2019-12-03 16:43:30 PST
Comment on attachment 384232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384232&action=review > Source/WebCore/dom/EventLoop.cpp:85 > + m_groupsWithSuspenedTasks.clear(); typo: m_groupsWithSuspenedTasks -> m_groupsWithSuspendedTasks > Source/WebCore/testing/Internals.h:780 > + ExceptionOr<void> queueMicrotaskInTask(Document&, const String& source, RefPtr<VoidCallback>&&); Kind of a strange name IMHO.
Ryosuke Niwa
Comment 7 2019-12-03 18:03:20 PST
(In reply to Chris Dumez from comment #6) > Comment on attachment 384232 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384232&action=review > > > Source/WebCore/dom/EventLoop.cpp:85 > > + m_groupsWithSuspenedTasks.clear(); > > typo: m_groupsWithSuspenedTasks -> m_groupsWithSuspendedTasks > > > Source/WebCore/testing/Internals.h:780 > > + ExceptionOr<void> queueMicrotaskInTask(Document&, const String& source, RefPtr<VoidCallback>&&); > > Kind of a strange name IMHO. How about queueTaskToQueueMicrotask?
Chris Dumez
Comment 8 2019-12-03 18:05:04 PST
(In reply to Ryosuke Niwa from comment #7) > (In reply to Chris Dumez from comment #6) > > Comment on attachment 384232 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=384232&action=review > > > > > Source/WebCore/dom/EventLoop.cpp:85 > > > + m_groupsWithSuspenedTasks.clear(); > > > > typo: m_groupsWithSuspenedTasks -> m_groupsWithSuspendedTasks > > > > > Source/WebCore/testing/Internals.h:780 > > > + ExceptionOr<void> queueMicrotaskInTask(Document&, const String& source, RefPtr<VoidCallback>&&); > > > > Kind of a strange name IMHO. > > How about queueTaskToQueueMicrotask? I like this better. It makes it clearer what the implementation actually does.
Ryosuke Niwa
Comment 9 2019-12-03 21:22:05 PST
Committed r253091: <https://trac.webkit.org/changeset/253091>
Note You need to log in before you can comment on or make changes to this bug.