Bug 204506
| Summary: | [css-grid] Serialization of custom identifiers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | clopez, jfernandez, obrufau, zsun |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=204611 https://bugs.webkit.org/show_bug.cgi?id=149890 |
||
Manuel Rego Casasnovas
Things like "\\31st" are not serialize like "\\31st" right now, this causes failures in http://w3c-test.org/css/css-grid/parsing/grid-area-computed.html (Blink and Firefox does this right).
This was discussed at https://github.com/w3c/csswg-drafts/issues/2858
Also grid-area: "--a" has similar problems, and http://w3c-test.org/css/css-grid/parsing/grid-area-shorthand.html also fails only in WebKit.
Not sure if it's exactly the same issue or 2 separated ones.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
(In reply to Manuel Rego Casasnovas from comment #0)
> Also grid-area: "--a" has similar problems, and
> http://w3c-test.org/css/css-grid/parsing/grid-area-shorthand.html also fails
> only in WebKit.
>
I guess grid-area-shorthand also fails due to bug 204611
Oriol Brufau
This seems to affect all properties that accept custom idents (animation-name is a non-grid example). Relevant comment:
// FIXME-NEWPARSER: Eventually we'd like this to use CSSCustomIdentValue, but we need
// to do other plumbing work first (like changing Pair to CSSValuePair and make it not
// use only primitive values).
RefPtr<CSSPrimitiveValue> consumeCustomIdent(CSSParserTokenRange& range)
zsun
This has been fixed at -
https://bugs.webkit.org/show_bug.cgi?id=226694
Oriol Brufau
*** This bug has been marked as a duplicate of bug 226694 ***