Bug 204344

Summary: Remove JSC 32bit ARMv7 and MipsEl old EWS queues
Product: WebKit Reporter: Paulo Matos <pmatos>
Component: New BugsAssignee: Paulo Matos <pmatos>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 203946    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Paulo Matos
Reported 2019-11-19 02:30:10 PST
Remove JSC 32bit ARMv7 and MipsEl old EWS queues
Attachments
Patch (1.64 KB, patch)
2019-11-19 02:30 PST, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Patch (4.79 KB, patch)
2019-11-20 06:08 PST, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Patch (4.14 KB, patch)
2019-11-22 06:37 PST, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Paulo Matos
Comment 1 2019-11-19 02:30:30 PST
Created attachment 383853 [details] Patch
Aakash Jain
Comment 2 2019-11-19 05:20:04 PST
You should remove it from Tools/QueueStatusServer/config/queues.py and Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js Also add it to Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py to enable the status-bubble on new EWS. Reference: https://trac.webkit.org/changeset/252453/webkit
Paulo Matos
Comment 3 2019-11-20 06:08:46 PST
Created attachment 383958 [details] Patch
Aakash Jain
Comment 4 2019-11-20 06:35:34 PST
Looks good. You don't need to remove it from Tools/Scripts/webkitpy/common/config/ews.json I will take care of it later on.
Paulo Matos
Comment 5 2019-11-20 06:58:14 PST
(In reply to Aakash Jain from comment #4) > Looks good. > > You don't need to remove it from > Tools/Scripts/webkitpy/common/config/ews.json I will take care of it later > on. Don't we need to remove this to disable the old ews?
Paulo Matos
Comment 6 2019-11-20 06:58:31 PST
r+ cq+
Aakash Jain
Comment 7 2019-11-20 07:22:54 PST
> Don't we need to remove this to disable the old ews? Not really, that’s how I removed rest of the queues from old EWS.
Aakash Jain
Comment 8 2019-11-21 04:22:48 PST
Comment on attachment 383958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383958&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:43 > 'ios-wk2', 'mac-wk1', 'mac-wk2', 'mac-debug-wk1', 'api-ios', 'api-mac', 'bindings', 'jsc', 'webkitperl', 'webkitpy', 'win', 'services'] Please add these queues to ALL_QUEUES as well. (Now that ENABLED_QUEUES is same as ALL_QUEUES, I need to remove the concept of ENABLED_QUEUES)
Paulo Matos
Comment 9 2019-11-22 06:37:34 PST
Created attachment 384149 [details] Patch
WebKit Commit Bot
Comment 10 2019-11-22 07:28:29 PST
Comment on attachment 384149 [details] Patch Clearing flags on attachment: 384149 Committed r252775: <https://trac.webkit.org/changeset/252775>
WebKit Commit Bot
Comment 11 2019-11-22 07:28:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2019-11-22 07:29:16 PST
<rdar://problem/57428468>
Aakash Jain
Comment 13 2019-11-28 08:08:51 PST
(In reply to Aakash Jain from comment #8) > (Now that ENABLED_QUEUES is same as ALL_QUEUES, I need to remove the concept of ENABLED_QUEUES) Done in https://trac.webkit.org/r252926
Note You need to log in before you can comment on or make changes to this bug.