Bug 204030

Summary:

Make MediaStream/MediaStreamTrack page cache friendly

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, rniwa, sergio, tommyw, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

youenn fablet

Reported 2019-11-08 16:30:02 PST

Make MediaStream/MediaStreamTrack page cache friendly

Attachments
Patch (8.20 KB, patch) 2019-11-08 17:10 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (8.92 KB, patch) 2019-11-08 18:47 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (5.49 KB, patch) 2019-11-11 09:37 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (8.23 KB, patch) 2019-11-11 09:58 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2019-11-08 17:10:58 PST

Created attachment 383183 [details] Patch

youenn fablet

Comment 2 2019-11-08 18:47:30 PST

Created attachment 383192 [details] Patch

Chris Dumez

Comment 3 2019-11-08 18:58:53 PST

Comment on attachment 383192 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383192&action=review > Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:578 > + scriptExecutionContext()->postTask([this, pendingActivity = makePendingActivity(*this)](auto&) { We're not supposed to use postTask() anymore. Please use the HTML event loop by calling queueTaskToDispatchEvent(). Also, because the HTML event loop is page-cache compliant, you can call queueTaskToDispatchEvent() in suspend() and then you don't need a resume() method or the m_isSuspendedForBackForwardCache flag.

youenn fablet

Comment 4 2019-11-11 09:37:35 PST

Created attachment 383276 [details] Patch

youenn fablet

Comment 5 2019-11-11 09:58:58 PST

Created attachment 383278 [details] Patch

Chris Dumez

Comment 6 2019-11-11 10:06:35 PST

Comment on attachment 383278 [details] Patch r=me if the bots are happy.

WebKit Commit Bot

Comment 7 2019-11-11 13:41:17 PST

Comment on attachment 383278 [details] Patch Clearing flags on attachment: 383278 Committed r252337: <https://trac.webkit.org/changeset/252337>