Bug 203763

Summary: [WebGL] Update WebGL 1 tests to prep for WebGL Conformance bot
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dino, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203908
https://bugs.webkit.org/show_bug.cgi?id=203909
https://bugs.webkit.org/show_bug.cgi?id=203949
Attachments:
Description Flags
WIP Patch for size concern
none
WIP patch for size concern
dino: review+
Patch for landing
none
Patch for landing
none
Patch w/ Changelog
none
Patch attempt none

Justin Fan
Reported 2019-11-01 14:47:42 PDT
[WebGL] Update WebGL 1 tests to prep for WebGL Conformance bot
Attachments
WIP Patch for size concern (10.87 MB, patch)
2019-11-03 22:42 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
WIP patch for size concern (11.21 MB, patch)
2019-11-03 23:00 PST, Justin Fan 		dino: review+
DetailsFormatted DiffDiff
Patch for landing (10.73 MB, patch)
2019-11-04 16:09 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.06 MB, patch)
2019-11-04 16:10 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch w/ Changelog (11.06 MB, patch)
2019-11-05 14:25 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch attempt (11.06 MB, patch)
2019-11-05 15:57 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-11-01 15:02:34 PDT
*** Bug 203766 has been marked as a duplicate of this bug. ***
Justin Fan
Comment 2 2019-11-03 22:42:19 PST
Created attachment 382717 [details] WIP Patch for size concern
Justin Fan
Comment 3 2019-11-03 23:00:48 PST
Created attachment 382718 [details] WIP patch for size concern
Justin Fan
Comment 4 2019-11-03 23:13:45 PST
Diff is so large patch is timing out. Yay
Dean Jackson
Comment 5 2019-11-04 13:38:51 PST
rs=me
Justin Fan
Comment 6 2019-11-04 16:09:52 PST
Created attachment 382783 [details] Patch for landing
Justin Fan
Comment 7 2019-11-04 16:10:24 PST
Created attachment 382784 [details] Patch for landing
Justin Fan
Comment 8 2019-11-05 14:25:26 PST
Created attachment 382850 [details] Patch w/ Changelog
Justin Fan
Comment 9 2019-11-05 15:57:38 PST
Created attachment 382856 [details] Patch attempt
Justin Fan
Comment 10 2019-11-05 17:03:00 PST
<rdar://problem/44468535>
Justin Fan
Comment 11 2019-11-05 19:01:45 PST
Committed r252121: <https://trac.webkit.org/changeset/252121>
Truitt Savell
Comment 12 2019-11-06 08:41:59 PST
The changes in https://trac.webkit.org/changeset/252121/webkit Broke several tests on iOS and introduced failing tests. 11 failing tests: webgl/1.0.3/conformance/extensions/get-extension.html webgl/1.0.3/conformance/extensions/oes-texture-float.html webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit.html webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html webgl/1.0.3/conformance/more/functions/readPixelsBadArgs.html webgl/1.0.3/conformance/more/functions/texImage2DHTML.html webgl/1.0.3/conformance/more/functions/texSubImage2DHTML.html webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html webgl/1.0.3/conformance/textures/texture-npot-video.html History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fget-extension.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Foes-texture-float.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-compressed-texture-size-limit.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-draw-buffers.html&test=webgl%2F1.0.3%2Fconformance%2Fglsl%2Fmisc%2Fshader-with-reserved-words.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FreadPixelsBadArgs.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexSubImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Frenderbuffers%2Fframebuffer-object-attachment.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Fcopy-tex-image-2d-formats.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Ftexture-npot-video.html&platform=ios
Truitt Savell
Comment 13 2019-11-06 08:50:15 PST
These two are also failing or timing out on Mac: webgl/1.0.3/conformance/textures/texture-npot-video.html webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html
Aakash Jain
Comment 14 2019-11-06 11:40:42 PST
webgl/1.0.3/conformance/context/context-release-upon-reload.html seems flaky, in https://ews-build.webkit.org/#/builders/17/builds/5817 , it passed in layout-tests step, but failed in re-run-layout-tests step.
Justin Fan
Comment 15 2019-11-07 14:18:20 PST
<rdar://problem/44468535>
Note You need to log in before you can comment on or make changes to this bug.