Bug 203416

Summary: [Web Animations] imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html is a failure
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, graouts, graouts, jacob_uphoff, nham, rackler, simon.fraser, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203291
https://bugs.webkit.org/show_bug.cgi?id=203477
https://bugs.webkit.org/show_bug.cgi?id=235131
Bug Depends on:    
Bug Blocks: 203477    
Attachments:
Description Flags
Update TestExpectations none

Antoine Quint
Reported 2019-10-25 08:17:09 PDT
The test imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html added as part of bug 203291 is a failure on iOS.
Attachments
Update TestExpectations (1.56 KB, patch)
2020-06-29 09:29 PDT, Karl Rackler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2019-10-25 08:20:27 PDT
Also, imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-001.html.
Truitt Savell
Comment 2 2019-10-25 11:23:37 PDT
Marked test as failing as part of https://trac.webkit.org/changeset/251597/webkit
Antoine Quint
Comment 3 2019-10-28 00:57:11 PDT
These also fail on GTK, added expectations in r251648.
Ben Nham
Comment 4 2020-02-13 16:56:07 PST
After https://bugs.webkit.org/show_bug.cgi?id=207516, which makes Mac first paint behave like iOS first paint, this test (before-load-001.html) will be skipped on Mac as well. Basically what this test is doing is animating a div from 1px to 100px over 0.1s and trying to make sure the animation can start before the load event fires. But since iOS (and now Mac) don't produce a first paint until we deem the paint significantly visually non-empty, the first paint can happen at the same time as the load event fires in WebKit. There's a comment in this test that says it tests behavior that isn't specified in the standard, so I'm not sure that the semantics of this test make sense for WebKit given our first paint policies. The one thing to look in to here is that maybe we should be triggering an emergency paint before the load event fires on iOS and Mac, which could make the test pass.
Karl Rackler
Comment 5 2020-06-29 09:28:38 PDT
imported/w3c/web-platform-tests/css/css-transitions/before-load-001.html is no longer failing - remove expectations Current history is green for Mac: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transitions%2Fbefore-load-001.html This test was isolated from the others in the group as one that is unexpectedly passing.
Karl Rackler
Comment 6 2020-06-29 09:29:18 PDT
Created attachment 403072 [details] Update TestExpectations
Radar WebKit Bug Importer
Comment 7 2020-06-29 09:32:37 PDT
<rdar://problem/64893646>
EWS
Comment 8 2020-06-29 11:48:12 PDT
Committed r263672: <https://trac.webkit.org/changeset/263672> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403072 [details].
Ryan Haddad
Comment 9 2020-06-29 16:44:58 PDT
Reopening since there are still tests failing.
Antoine Quint
Comment 10 2021-03-08 09:58:12 PST
Retitling since imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-001.html has been removed.
Antoine Quint
Comment 11 2021-03-08 10:03:01 PST
Committed r274078 (235014@main): <https://commits.webkit.org/235014@main>
Note You need to log in before you can comment on or make changes to this bug.