Bug 203277

Summary: Python 3: Add support in webkitpy.common.checkout.scm
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201956
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2019-10-22 15:42:38 PDT
All of webkitpy.common.checkout.scm needs to support Python 3.
Attachments
Patch (34.65 KB, patch)
2019-10-22 15:51 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (35.92 KB, patch)
2019-10-24 16:52 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-10-22 15:51:10 PDT
Created attachment 381621 [details] Patch
Jonathan Bedard
Comment 2 2019-10-24 16:52:20 PDT
Created attachment 381859 [details] Patch
Stephanie Lewis
Comment 3 2019-10-24 16:59:20 PDT
Comment on attachment 381859 [details] Patch Looks fine for the most part. I think the slow stuff should be its own patch
Jonathan Bedard
Comment 4 2019-10-24 17:11:19 PDT
(In reply to Jonathan Bedard from comment #2) > Created attachment 381859 [details] > Patch The slow stuff is a prerequisite to land this, otherwise the SCM tests make the test-webkitpy-python3 script unusably slow. The slow stuff can't really be tested without the SCM stuff, though.
WebKit Commit Bot
Comment 5 2019-10-24 23:52:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 381859 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2019-10-24 23:52:27 PDT
The commit-queue encountered the following flaky tests while processing attachment 381859 [details]: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2019-10-25 02:11:39 PDT
Comment on attachment 381859 [details] Patch Clearing flags on attachment: 381859 Committed r251587: <https://trac.webkit.org/changeset/251587>
WebKit Commit Bot
Comment 8 2019-10-25 02:11:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-10-25 02:12:16 PDT
<rdar://problem/56612397>
Note You need to log in before you can comment on or make changes to this bug.