Bug 203153

Summary: ElementRuleCollector function signature cleanups
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
windows build fix none

Antti Koivisto
Reported 2019-10-18 08:26:29 PDT
Many functions in ElementRuleCollector take repetitive arguments that can be removed: - Make includeEmptyRules argument a class member - Remove RuleRange argument, update the ranges in rule transfer step.
Attachments
patch (26.98 KB, patch)
2019-10-18 09:26 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
windows build fix (1.30 KB, patch)
2019-10-18 11:40 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-10-18 09:26:04 PDT
Created attachment 381307 [details] patch
WebKit Commit Bot
Comment 2 2019-10-18 11:07:59 PDT
The commit-queue encountered the following flaky tests while processing attachment 381307 [details]: inspector/console/webcore-logging.html bug 203118 (authors: drousso@apple.com and eric.carlson@apple.com) fast/events/resize-subframe-in-rendering-update.html bug 203140 (author: rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2019-10-18 11:08:50 PDT
Comment on attachment 381307 [details] patch Clearing flags on attachment: 381307 Committed r251289: <https://trac.webkit.org/changeset/251289>
WebKit Commit Bot
Comment 4 2019-10-18 11:08:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-10-18 11:09:19 PDT
<rdar://problem/56412684>
Antti Koivisto
Comment 6 2019-10-18 11:40:45 PDT
Created attachment 381318 [details] windows build fix
Antti Koivisto
Comment 7 2019-10-18 11:47:25 PDT
Build fix https://trac.webkit.org/r251291
Note You need to log in before you can comment on or make changes to this bug.