Bug 202869

Summary: Add [ActiveDOMObject] to IDLs of ActiveDOMObjects
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, benjamin, calvaris, commit-queue, dino, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, graouts, gyuyoung.kim, hi, jer.noble, jsbell, kondapallykalyan, macpherson, menard, mmaxfield, philipj, rniwa, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202293    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-10-11 16:46:06 PDT
Add [ActiveDOMObject] to IDLs of ActiveDOMObjects.
Attachments
Patch (8.36 KB, patch)
2019-10-11 16:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (86.31 KB, patch)
2019-10-11 21:20 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (85.27 KB, patch)
2019-10-11 21:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (85.81 KB, patch)
2019-10-12 14:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-10-11 16:49:30 PDT
Created attachment 380801 [details] Patch
Ryosuke Niwa
Comment 2 2019-10-11 19:16:10 PDT
Comment on attachment 380801 [details] Patch Can we also add a static_assert to make sure whatever object which is not marked as ActiveDOMObject doesn't inherit from ActiveDOMObject somehow?
Chris Dumez
Comment 3 2019-10-11 19:58:55 PDT
(In reply to Ryosuke Niwa from comment #2) > Comment on attachment 380801 [details] > Patch > > Can we also add a static_assert to make sure whatever object which is not > marked as ActiveDOMObject doesn't inherit from ActiveDOMObject somehow? I will give it a shot. It would be great to have indeed.
Ryosuke Niwa
Comment 4 2019-10-11 20:02:15 PDT
(In reply to Chris Dumez from comment #3) > (In reply to Ryosuke Niwa from comment #2) > > Comment on attachment 380801 [details] > > Patch > > > > Can we also add a static_assert to make sure whatever object which is not > > marked as ActiveDOMObject doesn't inherit from ActiveDOMObject somehow? > > I will give it a shot. It would be great to have indeed. Hopefully, a simple type traits or some of helper functions in https://en.cppreference.com/w/cpp/types should do the trick.
Chris Dumez
Comment 5 2019-10-11 21:20:18 PDT
Created attachment 380815 [details] Patch
Chris Dumez
Comment 6 2019-10-11 21:25:20 PDT
Created attachment 380816 [details] Patch
Chris Dumez
Comment 7 2019-10-11 21:55:40 PDT
Comment on attachment 380816 [details] Patch Clearing flags on attachment: 380816 Committed r251040: <https://trac.webkit.org/changeset/251040>
Chris Dumez
Comment 8 2019-10-11 21:55:43 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 9 2019-10-12 13:59:03 PDT
Looks like this introduced IDB debug assertion failures: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r251040%20(6218)/results.html
Chris Dumez
Comment 10 2019-10-12 13:59:51 PDT
(In reply to Ryosuke Niwa from comment #9) > Looks like this introduced IDB debug assertion failures: > https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/ > r251040%20(6218)/results.html :/ Will look.
Ryosuke Niwa
Comment 11 2019-10-12 14:02:40 PDT
We might want to roll it out for now since it broke some debug bots: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/5252 Bots are existing early after 50 failures.
Chris Dumez
Comment 12 2019-10-12 14:04:51 PDT
Reverted r251040 for reason: Broke IDB tests in Debug Committed r251051: <https://trac.webkit.org/changeset/251051>
Radar WebKit Bug Importer
Comment 13 2019-10-12 14:05:09 PDT
<rdar://problem/56222556>
Chris Dumez
Comment 14 2019-10-12 14:14:59 PDT
Created attachment 380834 [details] Patch
WebKit Commit Bot
Comment 15 2019-10-12 16:40:12 PDT
Comment on attachment 380834 [details] Patch Clearing flags on attachment: 380834 Committed r251053: <https://trac.webkit.org/changeset/251053>
WebKit Commit Bot
Comment 16 2019-10-12 16:40:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.