Bug 202560

Summary: [WebAuthn] Move the mock testing entrance to Internals
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.gaynor, bfulgham, cdumez, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182769, 202565    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
cdumez: review+, cdumez: commit-queue-
Patch for landing none

Jiewen Tan
Reported 2019-10-03 22:33:29 PDT
Figure out a way to bridge the current mock test infra into API test.
Attachments
Patch (189.45 KB, patch)
2019-10-08 20:27 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (205.92 KB, patch)
2019-10-09 01:53 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (189.54 KB, patch)
2019-10-09 01:59 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (190.43 KB, patch)
2019-10-09 11:56 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (190.37 KB, patch)
2019-10-09 12:26 PDT, Jiewen Tan 		cdumez: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (190.48 KB, patch)
2019-10-09 14:53 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-10-03 22:33:47 PDT
<rdar://problem/55973793>
Jiewen Tan
Comment 2 2019-10-08 20:27:31 PDT
Created attachment 380496 [details] Patch
Jiewen Tan
Comment 3 2019-10-09 01:53:03 PDT
Created attachment 380518 [details] Patch
Jiewen Tan
Comment 4 2019-10-09 01:59:58 PDT
Created attachment 380520 [details] Patch
Jiewen Tan
Comment 5 2019-10-09 11:56:22 PDT
Created attachment 380550 [details] Patch
Jiewen Tan
Comment 6 2019-10-09 12:26:05 PDT
Created attachment 380555 [details] Patch
Chris Dumez
Comment 7 2019-10-09 12:29:59 PDT
Comment on attachment 380555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380555&action=review > Source/WebCore/ChangeLog:9 > + This patch moves TestRunner.setWebAuthenticationMockConfiguration to Could you please explain the motivation behind this change? I looked at the patch and it is really not obvious to me why the new approach is better, considering that you need to IPC the UIProcess from WebCore using the ChromeClient now. TestRunner makes the IPC to the UIProcess trivial for you.
Jiewen Tan
Comment 8 2019-10-09 12:32:40 PDT
(In reply to Chris Dumez from comment #7) > Comment on attachment 380555 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380555&action=review > > > Source/WebCore/ChangeLog:9 > > + This patch moves TestRunner.setWebAuthenticationMockConfiguration to > > Could you please explain the motivation behind this change? I looked at the > patch and it is really not obvious to me why the new approach is better, > considering that you need to IPC the UIProcess from WebCore using the > ChromeClient now. > TestRunner makes the IPC to the UIProcess trivial for you. I need to use the mock infrastructure in API tests. I should add it to the ChangeLog.
Chris Dumez
Comment 9 2019-10-09 13:20:00 PDT
Comment on attachment 380555 [details] Patch r=me but please improve change log before landing.
Jiewen Tan
Comment 10 2019-10-09 14:53:42 PDT
Created attachment 380572 [details] Patch for landing
Jiewen Tan
Comment 11 2019-10-09 14:54:05 PDT
(In reply to Chris Dumez from comment #9) > Comment on attachment 380555 [details] > Patch > > r=me but please improve change log before landing. Thanks, Chris. Fixed the ChangeLog.
WebKit Commit Bot
Comment 12 2019-10-09 16:03:15 PDT
Comment on attachment 380572 [details] Patch for landing Clearing flags on attachment: 380572 Committed r250940: <https://trac.webkit.org/changeset/250940>
Note You need to log in before you can comment on or make changes to this bug.