Bug 202513

Created attachment 380099 [details] Patch

Created attachment 380212 [details] Patch

Comment on attachment 380212 [details] Patch Tests look green, marking for review/commit.

Comment on attachment 380212 [details] Patch Clearing flags on attachment: 380212 Committed r250772: <https://trac.webkit.org/changeset/250772>

All reviewed patches have been landed. Closing bug.

<rdar://problem/56031813>

New test imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.floatsource.html added in https://trac.webkit.org/changeset/250772/webkit is flaky. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Foffscreen-canvas%2Fdrawing-images-to-the-canvas%2F2d.drawImage.floatsource.html Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.floatsource-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.floatsource-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: line 29: Unhandled Promise Rejection: TypeError: null is not an object (evaluating 'ctx.drawImage') 2d.drawImage.floatsource

(In reply to Truitt Savell from comment #7) > New test > imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the- > canvas/2d.drawImage.floatsource.html > > added in https://trac.webkit.org/changeset/250772/webkit > > is flaky. > > History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Foffscreen- > canvas%2Fdrawing-images-to-the-canvas%2F2d.drawImage.floatsource.html > > Diff: > --- > /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/ > imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the- > canvas/2d.drawImage.floatsource-expected.txt > +++ > /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/ > imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the- > canvas/2d.drawImage.floatsource-actual.txt > @@ -1,3 +1,4 @@ > +CONSOLE MESSAGE: line 29: Unhandled Promise Rejection: TypeError: null is > not an object (evaluating 'ctx.drawImage') > 2d.drawImage.floatsource I'll add a DumpJSConsoleLogInStdErr expectation for this tomorrow morning.

This test is also flakey: offscreen-canvas/compositing/2d.composite.canvas.destination-in.html History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Foffscreen-canvas%2Fcompositing%2F2d.composite.canvas.destination-in.html

(In reply to Truitt Savell from comment #9) > This test is also flakey: > offscreen-canvas/compositing/2d.composite.canvas.destination-in.html > > History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Foffscreen- > canvas%2Fcompositing%2F2d.composite.canvas.destination-in.html Thanks, all the flaky tests this and the earlier link revealed have been marked in bug #202782 and bug #202801. I wouldn't be surprised of some more popping up, as I guess when the promises reject may vary depending on load/spec(?) This will be fixed properly by bug the work in bug 183720, after which we can remove these test expectations (as successful tests shouldn't output anything to the console).