Bug 202054

Summary: Remove dead code for a specific macOS and iOS SDK
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ews-watchlist, mmaxfield, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201851
https://bugs.webkit.org/show_bug.cgi?id=186571
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-09-20 13:14:15 PDT
ComplexTextController::collectComplexTextRunsForCharacters in ComplexTextControllerCoreText.mm has some code for compatibility with specifically macOS 10.14.0 and iOS 12.0 (see Bug 186571). We don't build for these targets any more (when we build for macOS 10.14, it's for a later minor revision), so this code can be removed.
Attachments
Patch (3.21 KB, patch)
2019-09-20 13:16 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-20 13:14:29 PDT
<rdar://problem/55569619>
Keith Rollin
Comment 2 2019-09-20 13:16:48 PDT
Created attachment 379263 [details] Patch
Alexey Proskuryakov
Comment 3 2019-09-20 16:34:14 PDT
Comment on attachment 379263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379263&action=review > Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm:-142 > -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED == 120000) While it is probably correct to make this change per the original explanation, please be aware that this is a behavior change. __MAC_OS_X_VERSION_MIN_REQUIRED still equals 101400 for builds that target 10.14.
WebKit Commit Bot
Comment 4 2019-09-20 17:36:12 PDT
Comment on attachment 379263 [details] Patch Clearing flags on attachment: 379263 Committed r250173: <https://trac.webkit.org/changeset/250173>
WebKit Commit Bot
Comment 5 2019-09-20 17:36:14 PDT
All reviewed patches have been landed. Closing bug.
Keith Rollin
Comment 6 2019-09-23 12:24:06 PDT
(In reply to Alexey Proskuryakov from comment #3) > While it is probably correct to make this change per the original > explanation, please be aware that this is a behavior change. > __MAC_OS_X_VERSION_MIN_REQUIRED still equals 101400 for builds that target > 10.14. Thanks. I didn't know that.
Note You need to log in before you can comment on or make changes to this bug.