Bug 201956

Summary: Python 3: Add support in webkitpy.common.checkout
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dewei_zhu, ews-watchlist, glenn, jbedard, jlewis3, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202462
https://bugs.webkit.org/show_bug.cgi?id=203277
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-09-18 17:02:46 PDT
Many scripts depend on code in webkitpy.common.checkout (there are also some cyclical dependencies with webkitpy.common.system), so we need to have support here soon.
Attachments
Patch (12.79 KB, patch)
2019-10-25 08:16 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (12.81 KB, patch)
2019-10-25 11:14 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.33 KB, patch)
2019-10-25 11:52 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-18 17:04:22 PDT
<rdar://problem/55499884>
Jonathan Bedard
Comment 2 2019-10-25 08:16:12 PDT
Created attachment 381925 [details] Patch
dewei_zhu
Comment 3 2019-10-25 10:53:07 PDT
Comment on attachment 381925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381925&action=review > Tools/ChangeLog:20 > + (Contributor.__hash__): Committers need to be washable. You mean 'hashable'? > Tools/Scripts/webkitpy/common/config/committers.py:82 > + for email in self._case_preserved_emails: Why we would like to use case preserved emails? Does it mean a@webkit.org and A@webkit.org are considered as different contributors? Also, we may want to explain why we need this function now in change log.
Jonathan Bedard
Comment 4 2019-10-25 11:09:44 PDT
Comment on attachment 381925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381925&action=review >> Tools/Scripts/webkitpy/common/config/committers.py:82 >> + for email in self._case_preserved_emails: > > Why we would like to use case preserved emails? Does it mean a@webkit.org and A@webkit.org are considered as different contributors? Also, we may want to explain why we need this function now in change log. This was a bit arbitrary, there is a case for me using what we do in __eq__, but that seems excessive. We need it so that we can put it into a set, I'll add that to the changelog.
Jonathan Bedard
Comment 5 2019-10-25 11:14:43 PDT
Created attachment 381945 [details] Patch
dewei_zhu
Comment 6 2019-10-25 11:20:21 PDT
Comment on attachment 381945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381945&action=review > Tools/Scripts/webkitpy/common/config/committers.py:84 > + def __hash__(self): > + result = hash(self.full_name) > + for email in self._case_preserved_emails: > + result ^= hash(email) > + return result Discussed with Jonathan in person, we think we should use all fields used in __eq__ to compute hash.
Jonathan Bedard
Comment 7 2019-10-25 11:52:54 PDT
Created attachment 381951 [details] Patch for landing
WebKit Commit Bot
Comment 8 2019-10-25 17:00:43 PDT
Comment on attachment 381951 [details] Patch for landing Clearing flags on attachment: 381951 Committed r251613: <https://trac.webkit.org/changeset/251613>
WebKit Commit Bot
Comment 9 2019-10-25 17:00:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.