Bug 201604

Summary: Ensure tests for legacy features are in LayoutTests/mathml
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbarton, ews-watchlist, rbuis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 201603    
Attachments:
Description Flags
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews212 for win-future
none
Patch
rbuis: review+
Patch for landing none

Frédéric Wang (:fredw)
Reported 2019-09-09 08:57:25 PDT
Some of them will be removed in 201603 instead checking that legacy features are not supported. Let's keep them in LayoutTests/mathml
Attachments
Patch (42.81 KB, patch)
2019-09-09 09:55 PDT, Frédéric Wang (:fredw) 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews212 for win-future (13.90 MB, application/zip)
2019-09-09 11:19 PDT, EWS Watchlist 		no flags
Details
Patch (43.80 KB, patch)
2019-09-09 20:22 PDT, Frédéric Wang (:fredw) 		rbuis: review+
DetailsFormatted DiffDiff
Patch for landing (43.89 KB, patch)
2019-09-10 07:00 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2019-09-09 09:55:53 PDT
Created attachment 378376 [details] Patch
EWS Watchlist
Comment 2 2019-09-09 11:19:17 PDT
Comment on attachment 378376 [details] Patch Attachment 378376 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13017160 New failing tests: mathml/non-core/lengths-3.html mathml/non-core/lengths-1.html
EWS Watchlist
Comment 3 2019-09-09 11:19:19 PDT
Created attachment 378389 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Frédéric Wang (:fredw)
Comment 4 2019-09-09 20:22:31 PDT
Created attachment 378438 [details] Patch
Rob Buis
Comment 5 2019-09-10 03:48:05 PDT
Comment on attachment 378438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378438&action=review > LayoutTests/ChangeLog:11 > + Reviewed by NOBODY (OOPS!). This should go up.
Frédéric Wang (:fredw)
Comment 6 2019-09-10 07:00:27 PDT
Created attachment 378460 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-09-10 07:45:48 PDT
Comment on attachment 378460 [details] Patch for landing Clearing flags on attachment: 378460 Committed r249713: <https://trac.webkit.org/changeset/249713>
WebKit Commit Bot
Comment 8 2019-09-10 07:45:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-09-10 07:46:24 PDT
<rdar://problem/55222023>
Note You need to log in before you can comment on or make changes to this bug.