Bug 201213

Summary:

[Win] Material icons font aren't shown because ligature doesn't work

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

don.olmstead, mmaxfield

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=247285

Bug Depends on:

Bug Blocks:

201214

Attachments:

Description	Flags
test case	none
test case	none
WIP patch	none
[screenshot] layout issues	none
WIP patch	none

Fujii Hironori

Reported 2019-08-27 22:08:09 PDT

[Win] Material icons font aren't shown https://material.io/resources/icons/

Attachments
test case (138 bytes, text/html) 2019-08-27 22:08 PDT, Fujii Hironori	no flags	Details
test case (268 bytes, text/html) 2019-08-27 22:31 PDT, Fujii Hironori	no flags	Details
WIP patch (548 bytes, patch) 2019-08-27 23:40 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
[screenshot] layout issues (94.13 KB, image/png) 2020-06-27 18:21 PDT, Fujii Hironori	no flags	Details
WIP patch (902 bytes, patch) 2020-06-29 18:10 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2019-08-27 22:08:20 PDT

Created attachment 377425 [details] test case

Fujii Hironori

Comment 2 2019-08-27 22:31:42 PDT

Created attachment 377426 [details] test case It seems that ligature doesn't work.

Fujii Hironori

Comment 3 2019-08-27 23:21:37 PDT

complex text code path can show ligature glyphs properly. And, DumpRenderTree.exe has --complex-text option. .\WebKitBuild\Debug\bin64\DumpRenderTree.exe --show-webview --complex-text https://bug-201213-attachments.webkit.org/attachment.cgi?id=377426

Fujii Hironori

Comment 4 2019-08-27 23:40:15 PDT

Created attachment 377432 [details] WIP patch

Fujii Hironori

Comment 5 2019-08-28 02:27:48 PDT

I found another issue of Windows port, and filed: Bug 201214 – [Win][UniscribeController] Material icons containing underscore or numbers aren't shown because ScriptItemize splits them apart

Myles C. Maxfield

Comment 6 2019-08-28 10:39:32 PDT

This looks like a good start.

Don Olmstead

Comment 7 2019-08-28 21:39:35 PDT

Comment on attachment 377432 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=377432&action=review > Source/WebCore/platform/graphics/FontCascade.h:281 > +#if PLATFORM(COCOA) || USE(FREETYPE) || PLATFORM(WIN) With PLATFORM(WIN) in there that’s everyone so might as well just return true and drop this check.

Don Olmstead

Comment 8 2019-08-28 21:49:28 PDT

(In reply to Fujii Hironori from comment #3) > complex text code path can show ligature glyphs properly. > > And, DumpRenderTree.exe has --complex-text option. > > .\WebKitBuild\Debug\bin64\DumpRenderTree.exe --show-webview --complex-text > https://bug-201213-attachments.webkit.org/attachment.cgi?id=377426 I’m reminded of https://bugs.webkit.org/show_bug.cgi?id=179102 Myles

Myles C. Maxfield

Comment 9 2020-06-18 14:05:11 PDT

(In reply to Don Olmstead from comment #8) > > I’m reminded of https://bugs.webkit.org/show_bug.cgi?id=179102 Myles What I've got in mind is specific to CoreText, but probably wouldn't be too difficult to hook the architecture I've got in mind up to HarfBuzz. I don't know about DirectWrite, though. Possibly.

Fujii Hironori

Comment 10 2020-06-26 15:43:38 PDT

GTK port is always using complex text code path as default. Bug 183285 – [GTK] Switch to use always complex text code path Bug 194614 – [WPE][GTK] Clean up handling of WEBKIT_FORCE_COMPLEX_TEXT

Fujii Hironori

Comment 11 2020-06-27 15:17:17 PDT

I confirmed GTK port doen't show the Material icons if I set the env ver WEBKIT_FORCE_COMPLEX_TEXT=0.

Fujii Hironori

Comment 12 2020-06-27 18:21:37 PDT

Created attachment 402978 [details] [screenshot] layout issues I found layout issues for this patch. https://b.hatena.ne.jp/hotentry/it * unexpected word breaks * narrow character spaces

Fujii Hironori

Comment 13 2020-06-27 21:22:27 PDT

(In reply to Fujii Hironori from comment #12) > * unexpected word breaks Filed: Bug 213691 – [WinCairo][Uniscribe] Katakana texts are unexpectedly wrapped because they don't fit into its own width

Fujii Hironori

Comment 14 2020-06-29 14:12:08 PDT

(In reply to Fujii Hironori from comment #12) > * narrow character spaces Filed: Bug 213754 – [WinCairo][Uniscribe] synthetic bold of embedded bitmap font glyphs are placed narrowly in complex text code path

Fujii Hironori

Comment 15 2020-06-29 18:10:24 PDT

Created attachment 403148 [details] WIP patch

Fujii Hironori

Comment 16 2020-08-10 13:19:32 PDT

Myles is working on it in Bug 215318. Closed as duplicate. *** This bug has been marked as a duplicate of bug 215318 ***

Note You need to log in before you can comment on or make changes to this bug.