Bug 201163

Summary: Update Test Expectations for iPad for fast/scrolling/ios/autoscroll-input-when-very-zoomed.html
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, repstein, simon.fraser, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Megan Gardner
Reported 2019-08-26 17:20:15 PDT
Update Test Expectations for iPad for fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt
Attachments
Patch (1.49 KB, patch)
2019-08-26 17:21 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (1.52 KB, patch)
2019-08-26 17:21 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2019-08-27 11:00 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2019-08-27 11:19 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (6.35 KB, patch)
2019-08-27 12:14 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-08-26 17:21:07 PDT
Created attachment 377296 [details] Patch
Megan Gardner
Comment 2 2019-08-26 17:21:52 PDT
Created attachment 377298 [details] Patch
WebKit Commit Bot
Comment 3 2019-08-26 17:25:17 PDT
Comment on attachment 377298 [details] Patch Rejecting attachment 377298 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 377298, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12970961
Wenson Hsieh
Comment 4 2019-08-27 09:24:12 PDT
<rdar://problem/54727027>
Megan Gardner
Comment 5 2019-08-27 11:00:17 PDT
Created attachment 377351 [details] Patch
Alexey Proskuryakov
Comment 6 2019-08-27 11:16:36 PDT
Comment on attachment 377351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377351&action=review > LayoutTests/ChangeLog:3 > + Update Test Expectations for iPad for fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt fast/scrolling/ios/autoscroll-input-when-very-zoomed.html > LayoutTests/platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt:2 > +FAIL: page has failed to scrolled on the first input Is the plan to make the test pass, or to keep it failing? I think that once it's fixed, the shared ios expectation will work, so I'm not sure is a separate -expected.txt is needed.
Megan Gardner
Comment 7 2019-08-27 11:18:51 PDT
Comment on attachment 377351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377351&action=review >> LayoutTests/platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt:2 >> +FAIL: page has failed to scrolled on the first input > > Is the plan to make the test pass, or to keep it failing? I think that once it's fixed, the shared ios expectation will work, so I'm not sure is a separate -expected.txt is needed. There are no plans to change this test. It works as expected on iPhone, and has been tuned to work there. It's either have failing test expectations, or skip the test, and I feel that failing test expectations are more helpful than a skipped test, so that is what I am doing, after discussing this with Simon and Tim.
Megan Gardner
Comment 8 2019-08-27 11:19:27 PDT
Created attachment 377355 [details] Patch
Alexey Proskuryakov
Comment 9 2019-08-27 11:28:19 PDT
Is this a test for functionality that is iPhone only, and doesn't exist on iPad? It doesn't sound so from the name of the test. I men, we don't have to make this test work, but then we'd need to create a new test for iPad, won't we?
Megan Gardner
Comment 10 2019-08-27 11:30:18 PDT
Then mark this test as failing on iPad; it tests an iPhone-specific behavior
Megan Gardner
Comment 11 2019-08-27 12:14:01 PDT
Created attachment 377360 [details] Patch
WebKit Commit Bot
Comment 12 2019-08-27 14:41:53 PDT
The commit-queue encountered the following flaky tests while processing attachment 377360 [details]: fullscreen/full-screen-request-removed-with-raf.html bug 201188 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 13 2019-08-27 14:42:38 PDT
Comment on attachment 377360 [details] Patch Clearing flags on attachment: 377360 Committed r249174: <https://trac.webkit.org/changeset/249174>
WebKit Commit Bot
Comment 14 2019-08-27 14:42:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.