Bug 200110

Summary:

Web Inspector: Network: don't allow the domain to be disabled

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, rniwa, Robertsandberg789, saam, tzagallo

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=200587
https://bugs.webkit.org/show_bug.cgi?id=200854

Bug Depends on:

200109

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Archive of layout-test-results from ews115 for mac-highsierra	none
Patch	none
Archive of layout-test-results from ews105 for mac-highsierra-wk2	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews117 for mac-highsierra	none
Patch	none
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews114 for mac-highsierra	none
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews113 for mac-highsierra	none

Devin Rousso

Reported 2019-07-24 20:43:31 PDT

Attachments
Patch (27.73 KB, patch) 2019-07-24 21:09 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (27.92 KB, patch) 2019-07-24 21:18 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (27.47 KB, patch) 2019-07-24 21:26 PDT, Devin Rousso	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (737.75 KB, application/zip) 2019-07-24 22:01 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-highsierra (2.37 MB, application/zip) 2019-07-24 22:07 PDT, EWS Watchlist	no flags	Details
Patch (13.10 KB, patch) 2019-07-24 22:13 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.43 MB, application/zip) 2019-07-24 22:53 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews101 for mac-highsierra (2.26 MB, application/zip) 2019-07-24 23:09 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (1.44 MB, application/zip) 2019-07-24 23:32 PDT, EWS Watchlist	no flags	Details
Patch (13.03 KB, patch) 2019-08-08 19:03 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (3.28 MB, application/zip) 2019-08-08 20:09 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-highsierra (3.49 MB, application/zip) 2019-08-08 20:55 PDT, EWS Watchlist	no flags	Details
Patch (15.96 KB, patch) 2019-08-12 11:36 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (15.88 KB, patch) 2019-08-12 11:55 PDT, Devin Rousso	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.22 MB, application/zip) 2019-08-12 12:58 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-highsierra (3.26 MB, application/zip) 2019-08-12 13:33 PDT, EWS Watchlist	no flags	Details
Show Obsolete (15) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-07-24 21:09:07 PDT

Created attachment 374862 [details] Patch

EWS Watchlist

Comment 2 2019-07-24 21:11:19 PDT Comment hidden (obsolete)

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

Devin Rousso

Comment 3 2019-07-24 21:18:29 PDT

Created attachment 374866 [details] Patch

Devin Rousso

Comment 4 2019-07-24 21:26:02 PDT

Created attachment 374868 [details] Patch

EWS Watchlist

Comment 5 2019-07-24 22:01:38 PDT Comment hidden (obsolete)

Comment on attachment 374868 [details] Patch Attachment 374868 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12807145 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 6 2019-07-24 22:01:39 PDT Comment hidden (obsolete)

Created attachment 374870 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-07-24 22:07:13 PDT Comment hidden (obsolete)

Comment on attachment 374868 [details] Patch Attachment 374868 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12807120 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 8 2019-07-24 22:07:15 PDT Comment hidden (obsolete)

Created attachment 374872 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 9 2019-07-24 22:13:06 PDT

Created attachment 374874 [details] Patch

EWS Watchlist

Comment 10 2019-07-24 22:53:05 PDT Comment hidden (obsolete)

Comment on attachment 374874 [details] Patch Attachment 374874 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12807389 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 11 2019-07-24 22:53:07 PDT Comment hidden (obsolete)

Created attachment 374875 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 12 2019-07-24 23:09:24 PDT Comment hidden (obsolete)

Comment on attachment 374874 [details] Patch Attachment 374874 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12807471 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 13 2019-07-24 23:09:26 PDT Comment hidden (obsolete)

Created attachment 374877 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 14 2019-07-24 23:32:08 PDT Comment hidden (obsolete)

Comment on attachment 374874 [details] Patch Attachment 374874 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12807470 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 15 2019-07-24 23:32:10 PDT Comment hidden (obsolete)

Created attachment 374880 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

Robert Sandberg

Comment 16 2019-08-04 21:53:26 PDT Comment hidden (spam)

Archive of layout-test-results from ews101 for mac-highsierra<a href="http://thestorelocator.co.uk">...</a>

Blaze Burg

Comment 17 2019-08-06 11:21:34 PDT

Comment on attachment 374874 [details] Patch LGTM, but can't r+ until the tests are fixed.

Devin Rousso

Comment 18 2019-08-07 10:21:18 PDT

(In reply to Brian Burg from comment #17) > LGTM, but can't r+ until the tests are fixed. The tests should be fixed once the blocking bug 200109 is fixed.

Devin Rousso

Comment 19 2019-08-08 19:03:54 PDT

Created attachment 375878 [details] Patch

EWS Watchlist

Comment 20 2019-08-08 20:09:07 PDT Comment hidden (obsolete)

Comment on attachment 375878 [details] Patch Attachment 375878 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12882755 New failing tests: http/tests/websocket/tests/hybi/inspector/before-load.html http/tests/websocket/tests/hybi/inspector/resolveWebSocket.html

EWS Watchlist

Comment 21 2019-08-08 20:09:09 PDT Comment hidden (obsolete)

Created attachment 375885 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 22 2019-08-08 20:55:38 PDT Comment hidden (obsolete)

Comment on attachment 375878 [details] Patch Attachment 375878 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12882809 New failing tests: http/tests/websocket/tests/hybi/inspector/resolveWebSocket.html http/tests/websocket/tests/hybi/inspector/before-load.html

EWS Watchlist

Comment 23 2019-08-08 20:55:40 PDT Comment hidden (obsolete)

Created attachment 375887 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 24 2019-08-12 11:36:50 PDT

Created attachment 376081 [details] Patch

Devin Rousso

Comment 25 2019-08-12 11:55:11 PDT

Created attachment 376083 [details] Patch Rebase

EWS Watchlist

Comment 26 2019-08-12 12:58:55 PDT Comment hidden (obsolete)

Comment on attachment 376083 [details] Patch Attachment 376083 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12899339 New failing tests: http/tests/inspector/network/har/har-basic.html inspector/runtime/change-execution-context-identifier.html

EWS Watchlist

Comment 27 2019-08-12 12:58:57 PDT Comment hidden (obsolete)

Created attachment 376086 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 28 2019-08-12 13:33:03 PDT Comment hidden (obsolete)

Comment on attachment 376083 [details] Patch Attachment 376083 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12899385 New failing tests: http/tests/inspector/network/har/har-basic.html inspector/runtime/change-execution-context-identifier.html

EWS Watchlist

Comment 29 2019-08-12 13:33:05 PDT Comment hidden (obsolete)

Created attachment 376091 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 30 2019-08-12 14:29:49 PDT Comment hidden (obsolete)

Comment on attachment 376083 [details] Patch Attachment 376083 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12899498 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla

Devin Rousso

Comment 31 2019-08-17 00:12:59 PDT

See <https://webkit.org/b/200854> for explanation.

Note You need to log in before you can comment on or make changes to this bug.