Bug 199844

Summary: Make ANGLE work inside WebKit2's sandbox
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bfulgham, commit-queue, dino, ews-watchlist, graouts, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: All   
Bug Depends on:    
Bug Blocks: 198948    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews212 for win-future none

Kenneth Russell
Reported 2019-07-16 16:51:10 PDT
WebKit's current ANGLE snapshot doesn't work inside WebKit2's sandbox because it makes a deprecated API call, CGDisplayIOServicePort, which is only used to determine the "active" GPU on dual-GPU MacBook Pros. It doesn't otherwise impact ANGLE's internal logic, nor consumers like WebCore. Top-of-tree ANGLE has removed this API call in http://crbug.com/angleproject/3383 . Cherry-picking that commit makes WebKit's ANGLE backend for WebGL work in WebKit2.
Attachments
Patch (24.22 KB, patch)
2019-07-16 17:01 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews212 for win-future (13.75 MB, application/zip)
2019-07-16 18:45 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2019-07-16 17:01:08 PDT
Created attachment 374264 [details] Patch
EWS Watchlist
Comment 2 2019-07-16 17:03:42 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2019-07-16 17:04:22 PDT
The attached patch is just an application of https://chromium-review.googlesource.com/1584360 with one merge conflict resolved, and also a tiny fix to WebGLLayer.mm fixing a build failure with USE_ANGLE=1 that I introduced at the last minute in my most recent patch (sorry!). It makes WebKit's ANGLE / WebGL backend run in WebKit2 mode in the minibrowser.
EWS Watchlist
Comment 4 2019-07-16 18:45:23 PDT
Comment on attachment 374264 [details] Patch Attachment 374264 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12754839 New failing tests: http/tests/css/filters-on-iframes-transform.html
EWS Watchlist
Comment 5 2019-07-16 18:45:25 PDT
Created attachment 374269 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Alexey Proskuryakov
Comment 6 2019-07-16 20:49:26 PDT
Could you please elaborate on what the user visible issue is? If we didn’t notice a full “doesn’t work”, that would be sad and surprising.
Radar WebKit Bug Importer
Comment 7 2019-07-16 20:49:48 PDT
<rdar://problem/53186410>
Alex Christensen
Comment 8 2019-07-17 10:22:10 PDT
Comment on attachment 374264 [details] Patch Kenneth is working on a WebGL implementation that not only uses ANGLE for shader translation, but also for rendering instead of using OpenGL/OpenGLES directly like we do now. This affects that WebGL implementation. ANGLE as a text-in-text-out translator does not need this change, so shipping WebGL is not broken and is unaffected by this patch. r=me
WebKit Commit Bot
Comment 9 2019-07-17 10:50:51 PDT
Comment on attachment 374264 [details] Patch Clearing flags on attachment: 374264 Committed r247521: <https://trac.webkit.org/changeset/247521>
WebKit Commit Bot
Comment 10 2019-07-17 10:50:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.