Bug 199839

Created attachment 374248 [details] Patch

We probably want a new umbrella bug or re-use 84635.

Comment on attachment 374248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374248&action=review > Source/WebCore/page/RuntimeEnabledFeatures.h:203 > + Nit: Whitespace.

Comment on attachment 374248 [details] Patch Attachment 374248 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12754104 New failing tests: imported/w3c/web-platform-tests/custom-elements/builtin-coverage.html imported/w3c/web-platform-tests/html/semantics/interfaces.html imported/w3c/web-platform-tests/html/dom/reflection-misc.html imported/blink/dialog/inert-node-is-not-highlighted.html imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode.html

Created attachment 374260 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

Comment on attachment 374248 [details] Patch Attachment 374248 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12754109 New failing tests: imported/w3c/web-platform-tests/custom-elements/builtin-coverage.html imported/w3c/web-platform-tests/html/semantics/interfaces.html imported/w3c/web-platform-tests/html/dom/reflection-misc.html imported/blink/dialog/inert-node-is-not-highlighted.html imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode.html

Created attachment 374262 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Comment on attachment 374248 [details] Patch Attachment 374248 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12754112 New failing tests: imported/w3c/web-platform-tests/custom-elements/builtin-coverage.html imported/blink/dialog/inert-node-is-not-highlighted.html imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode.html

Created attachment 374265 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6

Comment on attachment 374248 [details] Patch Attachment 374248 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12754105 New failing tests: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering.html imported/w3c/web-platform-tests/custom-elements/builtin-coverage.html imported/w3c/web-platform-tests/html/semantics/interfaces.html imported/w3c/web-platform-tests/html/dom/reflection-misc.html imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode.html

Created attachment 374266 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

Created attachment 374305 [details] Patch

Created attachment 374311 [details] Patch

Comment on attachment 374311 [details] Patch Clearing flags on attachment: 374311 Committed r247527: <https://trac.webkit.org/changeset/247527>

All reviewed patches have been landed. Closing bug.

<rdar://problem/53214201>

It looks like the changes in https://trac.webkit.org/changeset/247527/webkit may have caused three test to begin failing on WK2 but they look like rebaslines, can you confirm? imported/w3c/web-platform-tests/custom-elements/builtin-coverage.html imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode.html imported/w3c/web-platform-tests/html/semantics/interfaces.html Results: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r247527%20(5380)/results.html Diff of imported/w3c/web-platform-tests/custom-elements/builtin-coverage.html https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r247527%20(5380)/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-pretty-diff.html

They should be rebaselines. I'm looking into them right now.

Reopening to attach new patch.

Created attachment 374326 [details] Patch

Comment on attachment 374326 [details] Patch This ought to fix them.

The commit-queue encountered the following flaky tests while processing attachment 374326 [details]: storage/indexeddb/dont-wedge.html bug 199883 (authors: beidson@apple.com, commit-queue@webkit.org, dgrogan@chromium.org, and mark.lam@apple.com) The commit-queue is continuing to process your patch.

Comment on attachment 374326 [details] Patch Clearing flags on attachment: 374326 Committed r247539: <https://trac.webkit.org/changeset/247539>

All reviewed patches have been landed. Closing bug.

Just saw https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Finteractive-elements%2Fthe-dialog-element%2Fcentering.html was also failing due to this with Diff: https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r247536%20(5247)/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-pretty-diff.html

I rebaslined imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering.html in https://trac.webkit.org/changeset/247564/webkit