Bug 199738

(In reply to Carlos Alberto Lopez Perez from comment #0) > On https://bugs.webkit.org/show_bug.cgi?id=169916#c7 I discovered some tests > give different visual output depending if you run the tests with on an empty > $HOME or not. > > I guess this is related to some configuration of some library. Ouch. It could be something like some configuration being present (or not) in $HOME for the hinting and/or subpixel rendering settings for fonts, for example. > In order to make the output of the tests more predictable I think > run-webkit-tests should run with a temporal new homedir. Yes, or even have a separate home directory for each test case being run. Or point $HOME to an empty, non-writable directory (not sure if that would work). We may want to also set $XDG_CONFIG_HOME, $XDG_CACHE_DIR, and so on.

(In reply to Adrian Perez from comment #1) > (In reply to Carlos Alberto Lopez Perez from comment #0) > > On https://bugs.webkit.org/show_bug.cgi?id=169916#c7 I discovered some tests > > give different visual output depending if you run the tests with on an empty > > $HOME or not. > > > > I guess this is related to some configuration of some library. > > Ouch. It could be something like some configuration being present > (or not) in $HOME for the hinting and/or subpixel rendering settings > for fonts, for example. > > > In order to make the output of the tests more predictable I think > > run-webkit-tests should run with a temporal new homedir. > > Yes, or even have a separate home directory for each test case > being run. I will try to use a separate home directory per worker. > Or point $HOME to an empty, non-writable directory (not > sure if that would work). We may want to also set $XDG_CONFIG_HOME, > $XDG_CACHE_DIR, and so on. XDG_CONFIG_HOME and XDG_CACHE_DIR are filtered out from the user environment by the webkitpy driver for tests. So I think is enough with just setting $HOME because the value of this two variables default to $HOME/.confing and $HOME/.cache

Created attachment 374302 [details] Patch

Comment on attachment 374302 [details] Patch Ok. Not ready for review still due to revert of r247512

(In reply to Carlos Alberto Lopez Perez from comment #2) > (In reply to Adrian Perez from comment #1) > > (In reply to Carlos Alberto Lopez Perez from comment #0) > > > On https://bugs.webkit.org/show_bug.cgi?id=169916#c7 I discovered some tests > > > give different visual output depending if you run the tests with on an empty > > > $HOME or not. > > > > > > I guess this is related to some configuration of some library. > > > > Ouch. It could be something like some configuration being present > > (or not) in $HOME for the hinting and/or subpixel rendering settings > > for fonts, for example. > > > > > In order to make the output of the tests more predictable I think > > > run-webkit-tests should run with a temporal new homedir. > > > > Yes, or even have a separate home directory for each test case > > being run. > > I will try to use a separate home directory per worker. Wonderful, thanks. > > Or point $HOME to an empty, non-writable directory (not > > sure if that would work). We may want to also set $XDG_CONFIG_HOME, > > $XDG_CACHE_DIR, and so on. > > XDG_CONFIG_HOME and XDG_CACHE_DIR are filtered out from the user environment > by the webkitpy driver for tests. > So I think is enough with just setting $HOME because the value of this two > variables default to $HOME/.confing and $HOME/.cache Good point, I had forgotten about the env var filter. Setting $HOME will do.

Created attachment 374359 [details] Patch

Comment on attachment 374359 [details] Patch Clearing flags on attachment: 374359 Committed r247642: <https://trac.webkit.org/changeset/247642>

All reviewed patches have been landed. Closing bug.