Bug 199617

Summary: [GStreamer] Skip http/tests/media/hls/hls-video-resize.html
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WebKitGTKAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, eric.carlson, jeremyj-wk, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=125715
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Charlie Turner
Reported 2019-07-09 05:49:33 PDT
[GStreamer] Skip http/tests/media/hls/hls-video-resize.html
Attachments
Patch (3.61 KB, patch)
2019-07-09 06:25 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch (3.61 KB, patch)
2019-07-09 07:02 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.61 KB, patch)
2019-10-22 14:08 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Charlie Turner
Comment 1 2019-07-09 06:25:49 PDT
Created attachment 373711 [details] Patch
Charlie Turner
Comment 2 2019-07-09 06:27:11 PDT
CC Jeremy, perhaps as the original test author they have points to add, but it seems like an Apple specific test from my investigation.
Xabier Rodríguez Calvar
Comment 3 2019-07-09 06:30:14 PDT
Comment on attachment 373711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373711&action=review > LayoutTests/ChangeLog:13 > + However, there is a provision mentioned implicity that the UA can implicitly?
Charlie Turner
Comment 4 2019-07-09 07:02:20 PDT
Created attachment 373712 [details] Patch Fix spelling error and give it 24hr to see if Jeremy has anything further to add
Eric Carlson
Comment 5 2019-07-09 10:07:55 PDT
Comment on attachment 373712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373712&action=review > LayoutTests/ChangeLog:17 > + Generally speaking, the HTML spec says that HAVE_METADATA => video > + dimensions are available. Only when the state is < HAVE_METADATA > + is it specified that "If the element's readyState attribute is > + HAVE_NOTHING, then the [width, height] attributes must return 0." > + > + However, there is a provision mentioned implicitly that the UA can > + be in HAVE_METADATA and have received no video data. "When no > + video data is available (the element's readyState attribute is > + either HAVE_NOTHING, or HAVE_METADATA but no video data has yet > + been obtained at all..." It seems like it would be worth having the spec updated to get rid of the ambiguity, can you please file a spec bug?
Eric Carlson
Comment 6 2019-07-09 10:08:21 PDT
(In reply to Charlie Turner from comment #4) > Created attachment 373712 [details] > Patch > > Fix spelling error and give it 24hr to see if Jeremy has anything further to > add Jeremy is not longer actively contributing to WebKit
Charlie Turner
Comment 7 2019-07-10 02:14:46 PDT
(In reply to Eric Carlson from comment #5) > Comment on attachment 373712 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373712&action=review > > > LayoutTests/ChangeLog:17 > > + Generally speaking, the HTML spec says that HAVE_METADATA => video > > + dimensions are available. Only when the state is < HAVE_METADATA > > + is it specified that "If the element's readyState attribute is > > + HAVE_NOTHING, then the [width, height] attributes must return 0." > > + > > + However, there is a provision mentioned implicitly that the UA can > > + be in HAVE_METADATA and have received no video data. "When no > > + video data is available (the element's readyState attribute is > > + either HAVE_NOTHING, or HAVE_METADATA but no video data has yet > > + been obtained at all..." > > It seems like it would be worth having the spec updated to get rid of the > ambiguity, can you please file a spec bug? Sure, I filed https://github.com/whatwg/html/issues/4761 I will update here when I find out more about this.
Philippe Normand
Comment 8 2019-07-23 09:41:27 PDT
So this can land then?
Charlie Turner
Comment 9 2019-10-22 14:08:44 PDT
Created attachment 381598 [details] Patch for landing
Charlie Turner
Comment 10 2019-10-22 14:09:17 PDT
No movement on the spec bug, skipping in the absense of input from them.
WebKit Commit Bot
Comment 11 2019-10-22 15:34:48 PDT
Comment on attachment 381598 [details] Patch for landing Clearing flags on attachment: 381598 Committed r251462: <https://trac.webkit.org/changeset/251462>
WebKit Commit Bot
Comment 12 2019-10-22 15:34:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.