Bug 199509

Summary:

Import css/cssom-view test cases from WPT

Product:

WebKit

Reporter:

cathiechen <cathiechen>

Component:

CSS

Assignee:

cathiechen <cathiechen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, fred.wang, rbuis, rwlbuis, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

161611

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none
Patch	none
Patch	none

cathiechen

Reported 2019-07-05 00:44:55 PDT

Import css/cssom-view test cases from WPT.

Attachments
Patch (175.89 KB, patch) 2019-07-05 02:59 PDT, cathiechen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.72 MB, application/zip) 2019-07-05 04:56 PDT, EWS Watchlist	no flags	Details
Patch (179.32 KB, patch) 2019-07-05 07:21 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (179.81 KB, patch) 2019-07-05 09:43 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (179.82 KB, patch) 2019-07-06 03:16 PDT, cathiechen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

cathiechen

Comment 1 2019-07-05 02:59:49 PDT

Created attachment 373486 [details] Patch

EWS Watchlist

Comment 2 2019-07-05 04:56:41 PDT

Comment on attachment 373486 [details] Patch Attachment 373486 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12666833 New failing tests: imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline.html imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-horizontal-tb-writing-mode-and-rtl-direction.html imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline.html

EWS Watchlist

Comment 3 2019-07-05 04:56:43 PDT

Created attachment 373489 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

cathiechen

Comment 4 2019-07-05 07:21:14 PDT

Created attachment 373492 [details] Patch

cathiechen

Comment 5 2019-07-05 09:43:13 PDT

Created attachment 373504 [details] Patch

WebKit Commit Bot

Comment 6 2019-07-06 03:02:34 PDT

Comment on attachment 373504 [details] Patch Rejecting attachment 373504 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 373504, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Frederic Wang found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/12674725

cathiechen

Comment 7 2019-07-06 03:16:24 PDT

Created attachment 373565 [details] Patch

WebKit Commit Bot

Comment 8 2019-07-06 04:04:05 PDT

Comment on attachment 373565 [details] Patch Clearing flags on attachment: 373565 Committed r247193: <https://trac.webkit.org/changeset/247193>

WebKit Commit Bot

Comment 9 2019-07-06 04:04:06 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2019-07-06 04:05:18 PDT

<rdar://problem/52720270>

Note You need to log in before you can comment on or make changes to this bug.