Bug 198947

Summary: NetworkSession::networkStorageSession can return null
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2019-06-17 17:55:43 PDT
NetworkSession::networkStorageSession can return null
Attachments
Patch (16.91 KB, patch)
2019-06-17 17:57 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (30.93 KB, patch)
2019-06-17 18:01 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-06-17 17:57:44 PDT
Created attachment 372304 [details] Patch
Alex Christensen
Comment 2 2019-06-17 17:57:46 PDT
<rdar://problem/51394449>
Alex Christensen
Comment 3 2019-06-17 18:01:59 PDT
Created attachment 372307 [details] Patch
youenn fablet
Comment 4 2019-06-18 10:28:05 PDT
Comment on attachment 372307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372307&action=review > Source/WebKit/ChangeLog:22 > + (WebKit::WebResourceLoadStatisticsStore::removePrevalentDomains): ResourceLoadStatisticsStore.cpp/WebResourceLoadStatisticsStore changes should probably not be needed after changes landed in https://bugs.webkit.org/show_bug.cgi?id=198814.
Alex Christensen
Comment 5 2019-06-18 14:20:13 PDT
Comment on attachment 372307 [details] Patch They're just null checks, and a syntax change is needed no matter what, so I'll just land this. When we fix bug 194926 we'll be back to having references.
WebKit Commit Bot
Comment 6 2019-06-18 14:40:33 PDT
Comment on attachment 372307 [details] Patch Clearing flags on attachment: 372307 Committed r246569: <https://trac.webkit.org/changeset/246569>
WebKit Commit Bot
Comment 7 2019-06-18 14:40:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.