Bug 198044

Summary: Replace Util::run with runUntil that takes a bool reference instead of a pointer
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Tools / TestsAssignee: Alex Christensen <achristensen>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aestes, sam, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2019-05-20 10:14:21 PDT
Replace Util::run with Util::runUntil that takes a bool reference instead of a pointer
Attachments
Patch (643.25 KB, patch)
2019-05-20 10:29 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (647.10 KB, patch)
2019-05-20 10:33 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-05-20 10:29:21 PDT
Created attachment 370260 [details] Patch
Alex Christensen
Comment 2 2019-05-20 10:33:43 PDT
Created attachment 370261 [details] Patch
Sam Weinig
Comment 3 2019-05-20 11:02:44 PDT
Comment on attachment 370261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370261&action=review > Tools/TestWebKitAPI/Utilities.h:33 > -void run(bool* done); > +void runUntil(const bool& done); I made this (or at least I think it was me) a pointer rather than a reference because I thought it looked better at call sites to use the &. I still kind of feel that way, but not too strongly.
Alex Christensen
Comment 4 2019-05-20 11:33:13 PDT
(In reply to Sam Weinig from comment #3) > Comment on attachment 370261 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370261&action=review > > > Tools/TestWebKitAPI/Utilities.h:33 > > -void run(bool* done); > > +void runUntil(const bool& done); > > I made this (or at least I think it was me) a pointer rather than a > reference because I thought it looked better at call sites to use the &. I > still kind of feel that way, but not too strongly. I think the new name makes it clear what is going on, and I think this is a significant improvement.
Alex Christensen
Comment 5 2019-07-18 16:32:39 PDT
This has bit rotted, and apparently wasn't popular.
Note You need to log in before you can comment on or make changes to this bug.