Bug 197996

Summary:

[ews-build] Add clickable url in UI for uploaded S3 archive

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, ews-watchlist, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Aakash Jain

Reported 2019-05-17 13:27:39 PDT

We started uploading archives to S3 since https://bugs.webkit.org/show_bug.cgi?id=197922. It would be nice to have a clickable link in the UI for the archive URL.

Attachments
Patch (1.51 KB, patch) 2019-05-17 14:01 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Patch (1.64 KB, patch) 2019-05-17 14:34 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-05-17 14:01:29 PDT

Created attachment 370148 [details] Patch

Aakash Jain

Comment 2 2019-05-17 14:03:01 PDT

Sample run: https://ews-build.webkit-uat.org/#/builders/39/builds/542

EWS Watchlist

Comment 3 2019-05-17 14:04:32 PDT Comment hidden (obsolete)

Attachment 370148 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:793: [TransferToS3.start] Use of super on an old style class [pylint/E1002] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jonathan Bedard

Comment 4 2019-05-17 14:12:06 PDT

Comment on attachment 370148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370148&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:800 > + match = re.search(r'S3 URL: (?P<url>[^\s]+)', log_text) Can we have a comment here with an example of the line we're mapping?

Aakash Jain

Comment 5 2019-05-17 14:34:28 PDT

Created attachment 370153 [details] Patch

Aakash Jain

Comment 6 2019-05-17 14:35:35 PDT

> Can we have a comment here with an example of the line we're mapping? Added

EWS Watchlist

Comment 7 2019-05-17 14:37:36 PDT Comment hidden (obsolete)

Attachment 370153 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:793: [TransferToS3.start] Use of super on an old style class [pylint/E1002] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 8 2019-05-17 16:45:44 PDT

Comment on attachment 370153 [details] Patch Clearing flags on attachment: 370153 Committed r245489: <https://trac.webkit.org/changeset/245489>

WebKit Commit Bot

Comment 9 2019-05-17 16:45:46 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2019-05-17 16:47:04 PDT

<rdar://problem/50910773>

Note You need to log in before you can comment on or make changes to this bug.