Bug 197586

Summary: iOS JSC tests frequently exiting with exception after stress/json-stringify-string-builder-overflow.js.no-cjit-validate-phases
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, keith_miller, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch keith_miller: review+, keith_miller: commit-queue-

Michael Saboff
Reported 2019-05-03 16:18:55 PDT
This test uses lots of memory. We should restrict where we run it and if we do run it, e don't need to run all configurations.
Attachments
Patch (1.19 KB, patch)
2019-05-03 16:22 PDT, Michael Saboff 		keith_miller: review+
keith_miller: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2019-05-03 16:19:09 PDT
<rdar://problem/50458665>
Michael Saboff
Comment 2 2019-05-03 16:22:34 PDT
Created attachment 369015 [details] Patch
Keith Miller
Comment 3 2019-05-03 16:27:14 PDT
Comment on attachment 369015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369015&action=review r=me with change. > JSTests/stress/json-stringify-string-builder-overflow.js:4 > //@ skip if $architecture != "arm64" and $architecture != "x86-64" Can we remove this line since it doesn't do anything.
Michael Saboff
Comment 4 2019-05-03 16:31:47 PDT
(In reply to Keith Miller from comment #3) > Comment on attachment 369015 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369015&action=review > > r=me with change. > > > JSTests/stress/json-stringify-string-builder-overflow.js:4 > > //@ skip if $architecture != "arm64" and $architecture != "x86-64" > > Can we remove this line since it doesn't do anything. I'll move this above the //@ lines I added.
Michael Saboff
Comment 5 2019-05-03 16:34:54 PDT
Committed r244937: <https://trac.webkit.org/changeset/244937>
Note You need to log in before you can comment on or make changes to this bug.