Bug 197296

Summary: Web Inspector: DOM: rename "low power" to "display composited"
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, jer.noble, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2019-04-25 14:36:02 PDT
"low power" is not the correct term for this, as the power performance is somewhat implied (not a direct cause).
Attachments
Patch (36.41 KB, patch)
2019-04-25 15:20 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (35.64 KB, patch)
2019-05-03 14:55 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (35.61 KB, patch)
2019-05-03 15:49 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-04-25 15:20:21 PDT
Created attachment 368277 [details] Patch
Joseph Pecoraro
Comment 2 2019-04-29 14:23:50 PDT
Comment on attachment 368277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368277&action=review rs=me but I think there could be a better name for it still > Source/JavaScriptCore/ChangeLog:3 > + Web Inspector: DOM: rename "low power" to "display composted" Typo in all ChangeLogs from the bug title: "composted" => "composited" > Source/WebInspectorUI/UserInterface/Images/DisplayCompositedStateChanged.svg:2 > +<?xml version="1.0" encoding="utf-8"?> > +<!-- Copyright © 2013 Apple Inc. All rights reserved. --> This year should probably be 2010 instead of 2013. I see it is changing from an [L] to a [D]. > Source/WebInspectorUI/UserInterface/Models/MediaTimelineRecord.js:90 > + if (this._eventType === WI.MediaTimelineRecord.EventType.DisplayCompositedStateChanged) > + return this._isDisplayComposited ? WI.UIString("Started Display Compositing") : WI.UIString("Stopped Display Compositing"); This name sounds confusing to me. What is "Display Compositing"? I like the idea of "Started/Stopped Efficient Video Rendering" or something specific to the video compositing display.
Devin Rousso
Comment 3 2019-04-29 14:39:10 PDT
Comment on attachment 368277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368277&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + Web Inspector: DOM: rename "low power" to "display composted" > > Typo in all ChangeLogs from the bug title: "composted" => "composited" LOOL, nah we should call it "display composted" 😂 >> Source/WebInspectorUI/UserInterface/Images/DisplayCompositedStateChanged.svg:2 >> +<!-- Copyright © 2013 Apple Inc. All rights reserved. --> > > This year should probably be 2010 instead of 2013. I see it is changing from an [L] to a [D]. This was copied from `DOMDocument.svg` which is 2013.
Devin Rousso
Comment 4 2019-05-03 14:55:21 PDT
Created attachment 368996 [details] Patch
Devin Rousso
Comment 5 2019-05-03 15:49:38 PDT
Created attachment 369007 [details] Patch
WebKit Commit Bot
Comment 6 2019-05-03 16:08:25 PDT
Comment on attachment 369007 [details] Patch Clearing flags on attachment: 369007 Committed r244933: <https://trac.webkit.org/changeset/244933>
WebKit Commit Bot
Comment 7 2019-05-03 16:08:27 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-05-03 16:12:11 PDT
<rdar://problem/50461053>
Note You need to log in before you can comment on or make changes to this bug.