Bug 196698

Summary:

Support lazy image and iframe loading (loading="lazy")

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Images

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugmail, caezaris, christianoliff, cyb.ai.815, domfarolino, ews-watchlist, feliziani.emanuele, fred.wang, jonlee, jsn256, kngan, kyle.bavender, lwarlow, mail, mail, marek.aug, mathias, me, m.goleb+bugzilla, mike, m.kurz+webkitbugs, nicolas, pp.mizdra, rbuis, riccardo.magliocchetti, rik, rniwa, sabouhallawa, simon.fraser, sroberts, tomac, t.tom, vertigoback, webkit, webkit-bug-importer, yoav, zcorpan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

199794, 199795, 200662, 200764, 201460, 203557, 207901, 207902, 208094, 215566, 243199

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews113 for mac-highsierra	none
Archive of layout-test-results from ews200 for win-future	none
Patch	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews204 for win-future	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews205 for win-future	none
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews112 for mac-highsierra	none
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews114 for mac-highsierra	none
Archive of layout-test-results from ews205 for win-future	none
Archive of layout-test-results from ews105 for mac-highsierra-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Archive of layout-test-results from ews117 for mac-highsierra	none
Archive of layout-test-results from ews202 for win-future	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews113 for mac-highsierra	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Archive of layout-test-results from ews112 for mac-highsierra	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews112 for mac-highsierra	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews202 for win-future	none
Patch	none
Archive of layout-test-results from ews204 for win-future	none
Patch	none
Archive of layout-test-results from ews214 for win-future	none
Patch	none
Patch	none
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Archive of layout-test-results from ews117 for mac-highsierra	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews214 for win-future	none
Patch	none
Patch	none
Archive of layout-test-results from ews211 for win-future	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews103 for mac-highsierra	none
Archive of layout-test-results from ews114 for mac-highsierra	none
Patch	none
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews115 for mac-highsierra	none
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews117 for mac-highsierra	none
Patch	none
Patch	none

Simon Fraser (smfr)

Reported 2019-04-08 10:39:40 PDT

https://github.com/whatwg/html/pull/3752/files https://github.com/scott-little/lazyload

Attachments
Patch (151.94 KB, patch) 2019-04-19 08:55 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (9.26 MB, application/zip) 2019-04-19 13:25 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-highsierra (511.28 KB, application/zip) 2019-04-19 20:58 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews200 for win-future (7.52 MB, application/zip) 2019-04-20 09:00 PDT, EWS Watchlist	no flags	Details
Patch (151.94 KB, patch) 2019-04-21 03:44 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (16.97 MB, application/zip) 2019-04-21 05:14 PDT, EWS Watchlist	no flags	Details
Patch (152.01 KB, patch) 2019-04-21 06:09 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (152.06 KB, patch) 2019-04-21 09:28 PDT, Rob Buis	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews204 for win-future (13.02 MB, application/zip) 2019-04-22 07:14 PDT, EWS Watchlist	no flags	Details
Patch (153.29 KB, patch) 2019-04-23 00:29 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (164.25 KB, patch) 2019-04-23 01:21 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (164.78 KB, patch) 2019-04-23 02:02 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (164.82 KB, patch) 2019-04-23 03:59 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews205 for win-future (13.10 MB, application/zip) 2019-04-23 08:39 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews100 for mac-highsierra (3.12 MB, application/zip) 2019-04-23 09:53 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-highsierra (3.55 MB, application/zip) 2019-04-23 10:47 PDT, EWS Watchlist	no flags	Details
Patch (165.24 KB, patch) 2019-04-23 12:23 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.11 MB, application/zip) 2019-04-23 13:37 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-highsierra (3.97 MB, application/zip) 2019-04-23 14:46 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews205 for win-future (13.04 MB, application/zip) 2019-04-23 16:49 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (957.65 KB, application/zip) 2019-04-23 19:22 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (1.20 MB, application/zip) 2019-04-23 21:07 PDT, EWS Watchlist	no flags	Details
Patch (166.45 KB, patch) 2019-04-25 09:12 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (3.10 MB, application/zip) 2019-04-25 10:27 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.76 MB, application/zip) 2019-04-25 10:39 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (2.95 MB, application/zip) 2019-04-25 11:07 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews202 for win-future (13.07 MB, application/zip) 2019-04-25 11:24 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (3.56 MB, application/zip) 2019-04-25 14:19 PDT, EWS Watchlist	no flags	Details
Patch (166.07 KB, patch) 2019-04-27 02:51 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (921.57 KB, application/zip) 2019-04-27 03:54 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews100 for mac-highsierra (1.96 MB, application/zip) 2019-04-27 03:54 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-highsierra (449.42 KB, application/zip) 2019-04-27 04:01 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (837.31 KB, application/zip) 2019-04-27 04:26 PDT, EWS Watchlist	no flags	Details
Patch (167.30 KB, patch) 2019-05-01 00:16 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (3.09 MB, application/zip) 2019-05-01 01:30 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.61 MB, application/zip) 2019-05-01 01:43 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-highsierra (2.92 MB, application/zip) 2019-05-01 02:12 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (7.94 MB, application/zip) 2019-05-01 02:26 PDT, EWS Watchlist	no flags	Details
Patch (170.30 KB, patch) 2019-05-01 03:14 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.11 MB, application/zip) 2019-05-01 04:30 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-highsierra (2.89 MB, application/zip) 2019-05-01 05:10 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (7.53 MB, application/zip) 2019-05-01 05:23 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews202 for win-future (12.98 MB, application/zip) 2019-05-01 05:27 PDT, EWS Watchlist	no flags	Details
Patch (171.99 KB, patch) 2019-05-01 06:29 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews204 for win-future (12.93 MB, application/zip) 2019-05-01 08:34 PDT, EWS Watchlist	no flags	Details
Patch (172.36 KB, patch) 2019-06-12 02:59 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews214 for win-future (13.52 MB, application/zip) 2019-06-12 05:08 PDT, EWS Watchlist	no flags	Details
Patch (176.41 KB, patch) 2019-06-12 07:23 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (176.42 KB, patch) 2019-06-12 09:17 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (4.06 MB, application/zip) 2019-06-12 10:36 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (3.87 MB, application/zip) 2019-06-12 10:49 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (4.00 MB, application/zip) 2019-06-12 11:47 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.85 MB, application/zip) 2019-06-12 11:47 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews214 for win-future (14.00 MB, application/zip) 2019-06-12 12:26 PDT, EWS Watchlist	no flags	Details
Patch (182.28 KB, patch) 2019-06-13 00:57 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (179.73 KB, patch) 2019-06-13 03:08 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews211 for win-future (13.90 MB, application/zip) 2019-06-13 07:19 PDT, EWS Watchlist	no flags	Details
Patch (168.98 KB, patch) 2019-08-10 05:56 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (168.33 KB, patch) 2019-08-10 10:51 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (167.42 KB, patch) 2019-08-11 01:47 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.25 MB, application/zip) 2019-08-11 02:59 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-highsierra (3.03 MB, application/zip) 2019-08-11 03:42 PDT, EWS Watchlist	no flags	Details
Patch (165.40 KB, patch) 2019-08-11 04:27 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (3.20 MB, application/zip) 2019-08-11 05:40 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-highsierra (2.99 MB, application/zip) 2019-08-11 06:23 PDT, EWS Watchlist	no flags	Details
Patch (41.14 KB, patch) 2019-08-13 06:34 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (47.72 KB, patch) 2019-08-13 08:43 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.20 MB, application/zip) 2019-08-13 09:44 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (3.12 MB, application/zip) 2019-08-13 10:27 PDT, EWS Watchlist	no flags	Details
Patch (67.93 KB, patch) 2019-08-14 00:55 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (68.09 KB, patch) 2019-08-14 06:10 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (27) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-04-08 10:39:59 PDT

<rdar://problem/49701250>

Simon Fraser (smfr)

Comment 2 2019-04-08 10:45:26 PDT

<rdar://problem/35457900>

Rob Buis

Comment 3 2019-04-19 08:55:19 PDT

Created attachment 367803 [details] Patch

EWS Watchlist

Comment 4 2019-04-19 13:25:56 PDT

Comment on attachment 367803 [details] Patch Attachment 367803 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11933271 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 5 2019-04-19 13:25:58 PDT

Created attachment 367818 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 6 2019-04-19 20:58:37 PDT

Comment on attachment 367803 [details] Patch Attachment 367803 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11937929 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 7 2019-04-19 20:58:39 PDT

Created attachment 367871 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 8 2019-04-20 08:59:57 PDT

Comment on attachment 367803 [details] Patch Attachment 367803 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11940816 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 9 2019-04-20 09:00:04 PDT

Created attachment 367889 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Rob Buis

Comment 10 2019-04-21 03:44:44 PDT

Created attachment 367907 [details] Patch

EWS Watchlist

Comment 11 2019-04-21 05:14:47 PDT

Comment on attachment 367907 [details] Patch Attachment 367907 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11945100 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 12 2019-04-21 05:14:49 PDT

Created attachment 367908 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Rob Buis

Comment 13 2019-04-21 06:09:30 PDT

Created attachment 367909 [details] Patch

Rob Buis

Comment 14 2019-04-21 09:28:30 PDT

Created attachment 367913 [details] Patch

EWS Watchlist

Comment 15 2019-04-22 07:13:50 PDT

Comment on attachment 367913 [details] Patch Attachment 367913 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11957801 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html http/tests/images/draw-pattern-slow-load-large-image.html http/tests/lazyload/style-dimension.html

EWS Watchlist

Comment 16 2019-04-22 07:14:01 PDT

Created attachment 367938 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

Shawn Roberts

Comment 17 2019-04-22 09:08:32 PDT

EWS bots are hanging after processing this patch. Obsoleting the Patch so bots will stop processing.

Rob Buis

Comment 18 2019-04-22 09:22:17 PDT

(In reply to Shawn Roberts from comment #17) > EWS bots are hanging after processing this patch. > > Obsoleting the Patch so bots will stop processing. Do you think it is due to something in the patch or just random?

Shawn Roberts

Comment 19 2019-04-22 09:27:57 PDT

(In reply to Rob Buis from comment #18) > (In reply to Shawn Roberts from comment #17) > > EWS bots are hanging after processing this patch. > > > > Obsoleting the Patch so bots will stop processing. > > Do you think it is due to something in the patch or just random? No I don't think this was specific to your patch. This has happened with a few other patches on a few different queues.

Rob Buis

Comment 20 2019-04-23 00:29:36 PDT

Created attachment 368017 [details] Patch

Rob Buis

Comment 21 2019-04-23 01:21:32 PDT

Created attachment 368018 [details] Patch

Rob Buis

Comment 22 2019-04-23 02:02:22 PDT

Created attachment 368020 [details] Patch

Rob Buis

Comment 23 2019-04-23 03:59:30 PDT

Created attachment 368023 [details] Patch

EWS Watchlist

Comment 24 2019-04-23 08:39:08 PDT

Comment on attachment 368023 [details] Patch Attachment 368023 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11971500 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html http/tests/images/draw-pattern-slow-load-large-image.html http/tests/lazyload/style-dimension.html

EWS Watchlist

Comment 25 2019-04-23 08:39:20 PDT

Created attachment 368034 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

EWS Watchlist

Comment 26 2019-04-23 09:53:42 PDT

Comment on attachment 368023 [details] Patch Attachment 368023 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11972346 New failing tests: http/tests/lazyload/lazy.html http/tests/preload/single_download_preload_headers.php http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html http/tests/lazyload/style-dimension.html http/tests/preload/single_download_preload.html

EWS Watchlist

Comment 27 2019-04-23 09:53:44 PDT

Created attachment 368038 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 28 2019-04-23 10:47:52 PDT

Comment on attachment 368023 [details] Patch Attachment 368023 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11972424 New failing tests: imported/w3c/web-platform-tests/preload/single-download-preload.html http/tests/lazyload/lazy.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.complexcolours.html http/tests/preload/single_download_preload_headers.php imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.quality.basic.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.dataURI.html http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.primarycolours.html http/tests/lazyload/style-dimension.html http/tests/preload/single_download_preload.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.alpha.html

EWS Watchlist

Comment 29 2019-04-23 10:47:55 PDT

Created attachment 368042 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6

Rob Buis

Comment 30 2019-04-23 12:23:15 PDT

Created attachment 368051 [details] Patch

EWS Watchlist

Comment 31 2019-04-23 13:37:24 PDT

Comment on attachment 368051 [details] Patch Attachment 368051 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11974565 New failing tests: http/tests/lazyload/lazy.html http/tests/preload/single_download_preload_headers.php http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html http/tests/lazyload/style-dimension.html http/tests/preload/single_download_preload.html

EWS Watchlist

Comment 32 2019-04-23 13:37:26 PDT

Created attachment 368059 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 33 2019-04-23 14:46:37 PDT

Comment on attachment 368051 [details] Patch Attachment 368051 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11974962 New failing tests: imported/w3c/web-platform-tests/preload/single-download-preload.html http/tests/lazyload/lazy.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.complexcolours.html http/tests/preload/single_download_preload_headers.php imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.quality.basic.html http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.primarycolours.html http/tests/lazyload/style-dimension.html http/tests/preload/single_download_preload.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.alpha.html

EWS Watchlist

Comment 34 2019-04-23 14:46:39 PDT

Created attachment 368067 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 35 2019-04-23 16:49:24 PDT

Comment on attachment 368051 [details] Patch Attachment 368051 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11976043 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html http/tests/images/draw-pattern-slow-load-large-image.html http/tests/lazyload/style-dimension.html

EWS Watchlist

Comment 36 2019-04-23 16:49:37 PDT

Created attachment 368084 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

EWS Watchlist

Comment 37 2019-04-23 19:22:36 PDT

Comment on attachment 368051 [details] Patch Attachment 368051 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11978026 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 38 2019-04-23 19:22:38 PDT

Created attachment 368103 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 39 2019-04-23 21:07:42 PDT

Comment on attachment 368051 [details] Patch Attachment 368051 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11978590 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 40 2019-04-23 21:07:44 PDT

Created attachment 368109 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Rob Buis

Comment 41 2019-04-25 09:12:35 PDT

Created attachment 368239 [details] Patch

EWS Watchlist

Comment 42 2019-04-25 10:27:03 PDT

Comment on attachment 368239 [details] Patch Attachment 368239 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11995739 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/style-dimension.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html

EWS Watchlist

Comment 43 2019-04-25 10:27:09 PDT

Created attachment 368244 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 44 2019-04-25 10:39:37 PDT

Comment on attachment 368239 [details] Patch Attachment 368239 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11995761 New failing tests: http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html

EWS Watchlist

Comment 45 2019-04-25 10:39:40 PDT

Created attachment 368248 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 46 2019-04-25 11:07:39 PDT

Comment on attachment 368239 [details] Patch Attachment 368239 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11995823 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/style-dimension.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html

EWS Watchlist

Comment 47 2019-04-25 11:07:41 PDT

Created attachment 368250 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 48 2019-04-25 11:23:49 PDT

Comment on attachment 368239 [details] Patch Attachment 368239 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11995929 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/style-dimension.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html

EWS Watchlist

Comment 49 2019-04-25 11:24:02 PDT

Created attachment 368252 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

EWS Watchlist

Comment 50 2019-04-25 14:19:08 PDT

Comment on attachment 368239 [details] Patch Attachment 368239 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11997383 New failing tests: http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html

EWS Watchlist

Comment 51 2019-04-25 14:19:10 PDT

Created attachment 368270 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Rob Buis

Comment 52 2019-04-27 02:51:42 PDT

Created attachment 368394 [details] Patch

EWS Watchlist

Comment 53 2019-04-27 03:54:24 PDT

Comment on attachment 368394 [details] Patch Attachment 368394 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12014708 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 54 2019-04-27 03:54:26 PDT

Created attachment 368396 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 55 2019-04-27 03:54:51 PDT

Comment on attachment 368394 [details] Patch Attachment 368394 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12014721 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 56 2019-04-27 03:54:54 PDT

Created attachment 368397 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 57 2019-04-27 04:01:31 PDT

Comment on attachment 368394 [details] Patch Attachment 368394 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12014689 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 58 2019-04-27 04:01:33 PDT

Created attachment 368398 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 59 2019-04-27 04:26:46 PDT

Comment on attachment 368394 [details] Patch Attachment 368394 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12014742 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 60 2019-04-27 04:26:48 PDT

Created attachment 368399 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4

Rob Buis

Comment 61 2019-05-01 00:16:09 PDT

Created attachment 368651 [details] Patch

EWS Watchlist

Comment 62 2019-05-01 01:30:01 PDT

Comment on attachment 368651 [details] Patch Attachment 368651 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12049500 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/style-dimension.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html

EWS Watchlist

Comment 63 2019-05-01 01:30:03 PDT

Created attachment 368652 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 64 2019-05-01 01:43:47 PDT

Comment on attachment 368651 [details] Patch Attachment 368651 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12049534 New failing tests: fast/filter-image/filter-image-svg.html

EWS Watchlist

Comment 65 2019-05-01 01:43:50 PDT

Created attachment 368653 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 66 2019-05-01 02:12:49 PDT

Comment on attachment 368651 [details] Patch Attachment 368651 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12049555 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/style-dimension.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html

EWS Watchlist

Comment 67 2019-05-01 02:12:51 PDT

Created attachment 368654 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 68 2019-05-01 02:26:09 PDT

Comment on attachment 368651 [details] Patch Attachment 368651 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12049577 New failing tests: fast/filter-image/filter-image-svg.html

EWS Watchlist

Comment 69 2019-05-01 02:26:12 PDT

Created attachment 368656 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4

Rob Buis

Comment 70 2019-05-01 03:14:09 PDT

Created attachment 368657 [details] Patch

EWS Watchlist

Comment 71 2019-05-01 04:30:09 PDT

Comment on attachment 368657 [details] Patch Attachment 368657 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12050478 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_on_image.tentative.html

EWS Watchlist

Comment 72 2019-05-01 04:30:11 PDT

Created attachment 368659 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 73 2019-05-01 05:10:53 PDT

Comment on attachment 368657 [details] Patch Attachment 368657 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12050509 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_on_image.tentative.html

EWS Watchlist

Comment 74 2019-05-01 05:10:56 PDT

Created attachment 368661 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 75 2019-05-01 05:23:43 PDT

Comment on attachment 368657 [details] Patch Attachment 368657 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12050531 New failing tests: http/tests/lazyload/attribute.html

EWS Watchlist

Comment 76 2019-05-01 05:23:46 PDT

Created attachment 368663 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4

EWS Watchlist

Comment 77 2019-05-01 05:27:37 PDT

Comment on attachment 368657 [details] Patch Attachment 368657 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12050574 New failing tests: http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html http/tests/lazyload/style-dimension.html

EWS Watchlist

Comment 78 2019-05-01 05:27:50 PDT

Created attachment 368665 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

Rob Buis

Comment 79 2019-05-01 06:29:34 PDT

Created attachment 368666 [details] Patch

Rob Buis

Comment 80 2019-05-01 06:39:29 PDT

This patch should be green now, or close. It is based on chromium's implementation, with the exception that for loading=auto or unspecified this patch will keep old loading behavior (eager) since otherwise too many tests would break. The patch is not really for review right now as the spec is still evolving and the patch is too big. I am thinking of splitting it up like this: - Import WPT lazy image loading tests (should be submitted to WPT first). - Add runtime flag and DRT/test runner glue code. - Implementation of core lazy image loading. - CSS Background image support. - IFrame lazy loading (not started yet). I guess this means adding sub issues to this bug.

EWS Watchlist

Comment 81 2019-05-01 08:34:37 PDT

Comment on attachment 368666 [details] Patch Attachment 368666 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12051450 New failing tests: http/tests/lazyload/attribute.html

EWS Watchlist

Comment 82 2019-05-01 08:34:49 PDT

Created attachment 368673 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

Rob Buis

Comment 83 2019-06-12 02:59:43 PDT

Created attachment 371939 [details] Patch

EWS Watchlist

Comment 84 2019-06-12 05:08:42 PDT

Comment on attachment 371939 [details] Patch Attachment 371939 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12453002 New failing tests: http/tests/lazyload/attribute.html

EWS Watchlist

Comment 85 2019-06-12 05:08:46 PDT

Created attachment 371941 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Rob Buis

Comment 86 2019-06-12 07:23:07 PDT

Created attachment 371951 [details] Patch

EWS Watchlist

Comment 87 2019-06-12 07:25:55 PDT

Attachment 371951 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ImageLoader.cpp:189: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 88 files If any of these errors are false positives, please file a bug against check-webkit-style.

Rob Buis

Comment 88 2019-06-12 09:17:23 PDT

Created attachment 371967 [details] Patch

EWS Watchlist

Comment 89 2019-06-12 09:19:50 PDT

Attachment 371967 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ImageLoader.cpp:189: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 88 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 90 2019-06-12 10:36:44 PDT

Comment on attachment 371967 [details] Patch Attachment 371967 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12455919 New failing tests: fast/events/mouse-focus-imagemap.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_empty.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.html imported/w3c/web-platform-tests/content-security-policy/unsafe-hashes/style_attribute_allowed.html fast/dom/beforeload/cached-image-before-load.html http/tests/lazyload/fixed-dimension.html accessibility/text-marker/character-offset-visible-position-conversion-hang.html fast/hidpi/image-srcset-simple-in-variable-2x.html http/tests/lazyload/attribute.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_unspecified.html http/tests/security/load-image-after-redirection-2.html http/tests/lazyload/style-dimension.html fast/dom/HTMLAnchorElement/anchor-ismap-crash.html fast/images/animated-gif-webkit-transform.html css3/filters/should-not-have-compositing-layer.html http/tests/security/load-image-after-redirection.html fast/css-grid-layout/grid-align-baseline.html

EWS Watchlist

Comment 91 2019-06-12 10:36:47 PDT

Created attachment 371972 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 92 2019-06-12 10:49:29 PDT

Comment on attachment 371967 [details] Patch Attachment 371967 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12455973 New failing tests: http/tests/lazyload/lazy.html http/tests/security/load-image-after-redirection-2.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_empty.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.html imported/w3c/web-platform-tests/content-security-policy/unsafe-hashes/style_attribute_allowed.html fast/events/mouse-focus-imagemap.html http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html fast/hidpi/image-srcset-simple-in-variable-2x.html accessibility/text-marker/character-offset-visible-position-conversion-hang.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_unspecified.html http/tests/lazyload/style-dimension.html fast/images/animated-gif-scrolling-crash.html fast/images/animated-gif-webkit-transform.html css3/filters/should-not-have-compositing-layer.html fast/dom/beforeload/cached-image-before-load.html http/tests/security/load-image-after-redirection.html fast/css-grid-layout/grid-align-baseline.html

EWS Watchlist

Comment 93 2019-06-12 10:49:32 PDT

Created attachment 371974 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 94 2019-06-12 11:47:19 PDT

Comment on attachment 371967 [details] Patch Attachment 371967 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12456135 New failing tests: fast/events/mouse-focus-imagemap.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_empty.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.html imported/w3c/web-platform-tests/content-security-policy/unsafe-hashes/style_attribute_allowed.html fast/dom/beforeload/cached-image-before-load.html http/tests/lazyload/fixed-dimension.html accessibility/text-marker/character-offset-visible-position-conversion-hang.html fast/hidpi/image-srcset-simple-in-variable-2x.html http/tests/lazyload/attribute.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_unspecified.html http/tests/security/load-image-after-redirection-2.html http/tests/lazyload/style-dimension.html fast/images/animated-gif-webkit-transform.html css3/filters/should-not-have-compositing-layer.html http/tests/security/load-image-after-redirection.html fast/css-grid-layout/grid-align-baseline.html

EWS Watchlist

Comment 95 2019-06-12 11:47:21 PDT

Created attachment 371978 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 96 2019-06-12 11:47:46 PDT

Comment on attachment 371967 [details] Patch Attachment 371967 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12456098 New failing tests: http/tests/lazyload/lazy.html http/tests/security/load-image-after-redirection-2.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_empty.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.html imported/w3c/web-platform-tests/content-security-policy/unsafe-hashes/style_attribute_allowed.html http/tests/lazyload/fixed-dimension.html fast/dom/beforeload/cached-image-before-load.html http/tests/webgl/1.0.2/origin-clean-conformance.html accessibility/text-marker/character-offset-visible-position-conversion-hang.html fast/hidpi/image-srcset-simple-in-variable-2x.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_unspecified.html http/tests/lazyload/style-dimension.html fast/images/animated-gif-scrolling-crash.html css3/filters/should-not-have-compositing-layer.html http/tests/security/load-image-after-redirection.html

EWS Watchlist

Comment 97 2019-06-12 11:47:48 PDT

Created attachment 371979 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

EWS Watchlist

Comment 98 2019-06-12 12:26:26 PDT

Comment on attachment 371967 [details] Patch Attachment 371967 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12456468 New failing tests: http/tests/security/load-image-after-redirection-2.html fast/events/mouse-focus-imagemap.html fast/dom/beforeload/cached-image-before-load.html http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html http/tests/lazyload/style-dimension.html fast/dom/HTMLAnchorElement/anchor-ismap-crash.html css3/filters/should-not-have-compositing-layer.html http/tests/security/load-image-after-redirection.html

EWS Watchlist

Comment 99 2019-06-12 12:26:29 PDT

Created attachment 371980 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Rob Buis

Comment 100 2019-06-13 00:57:25 PDT

Created attachment 372030 [details] Patch

Rob Buis

Comment 101 2019-06-13 03:08:03 PDT

Created attachment 372041 [details] Patch

EWS Watchlist

Comment 102 2019-06-13 07:19:10 PDT

Comment on attachment 372041 [details] Patch Attachment 372041 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12463952 New failing tests: http/tests/lazyload/attribute.html

EWS Watchlist

Comment 103 2019-06-13 07:19:15 PDT

Created attachment 372050 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Rob Buis

Comment 104 2019-08-10 05:56:29 PDT

Created attachment 376011 [details] Patch

Rob Buis

Comment 105 2019-08-10 10:51:50 PDT

Created attachment 376015 [details] Patch

Rob Buis

Comment 106 2019-08-11 01:47:28 PDT

Created attachment 376033 [details] Patch

EWS Watchlist

Comment 107 2019-08-11 02:59:52 PDT

Comment on attachment 376033 [details] Patch Attachment 376033 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12893740 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_invalid_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_auto_image.tentative.html http/tests/lazyload/fixed-dimension.html imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_unset_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/attribute_off_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/window_load_event_occurs_with_below_viewport_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/change_attribute_to_off_image.tentative.html

EWS Watchlist

Comment 108 2019-08-11 02:59:55 PDT

Created attachment 376034 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 109 2019-08-11 03:42:22 PDT

Comment on attachment 376033 [details] Patch Attachment 376033 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12893769 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_invalid_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_auto_image.tentative.html http/tests/lazyload/fixed-dimension.html imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_unset_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/attribute_off_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/window_load_event_occurs_with_below_viewport_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/change_attribute_to_off_image.tentative.html

EWS Watchlist

Comment 110 2019-08-11 03:42:25 PDT

Created attachment 376035 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

Rob Buis

Comment 111 2019-08-11 04:27:07 PDT

Created attachment 376036 [details] Patch

EWS Watchlist

Comment 112 2019-08-11 05:40:44 PDT

Comment on attachment 376036 [details] Patch Attachment 376036 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12894196 New failing tests: http/tests/lazyload/fixed-dimension.html

EWS Watchlist

Comment 113 2019-08-11 05:40:47 PDT

Created attachment 376039 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 114 2019-08-11 06:23:53 PDT

Comment on attachment 376036 [details] Patch Attachment 376036 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12894207 New failing tests: http/tests/lazyload/fixed-dimension.html

EWS Watchlist

Comment 115 2019-08-11 06:23:56 PDT

Created attachment 376040 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6

Rob Buis

Comment 116 2019-08-13 06:34:00 PDT

Created attachment 376158 [details] Patch

Rob Buis

Comment 117 2019-08-13 08:43:51 PDT

Created attachment 376167 [details] Patch

EWS Watchlist

Comment 118 2019-08-13 09:44:52 PDT

Comment on attachment 376167 [details] Patch Attachment 376167 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12904837 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/image-loading-lazy.tentative.html

EWS Watchlist

Comment 119 2019-08-13 09:44:55 PDT

Created attachment 376176 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 120 2019-08-13 10:27:05 PDT

Comment on attachment 376167 [details] Patch Attachment 376167 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12904894 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/image-loading-lazy.tentative.html

EWS Watchlist

Comment 121 2019-08-13 10:27:08 PDT

Created attachment 376180 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

Rob Buis

Comment 122 2019-08-14 00:55:08 PDT

Created attachment 376246 [details] Patch

Rob Buis

Comment 123 2019-08-14 06:10:05 PDT

Created attachment 376259 [details] Patch

m.kurz+webkitbugs

Comment 124 2020-02-12 23:49:22 PST

The according Firefox issue just was marked as resolved. Support for the "loading" attribute will ship with Firefox 75: https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 Safari is the only major browser lacking this feature...

Rob Buis

Comment 125 2020-02-13 00:04:07 PST

Gute morgen, (In reply to m.kurz+webkitbugs from comment #124) > The according Firefox issue just was marked as resolved. Support for the > "loading" attribute will ship with Firefox 75: > https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 > > Safari is the only major browser lacking this feature... I was waiting for the spec to land before working again on this. First step is to fix the tests: https://github.com/web-platform-tests/wpt/pull/21773 I'll incorporate them into https://bugs.webkit.org/show_bug.cgi?id=200764, test a bit and hopefully put it up for review soon.

Dominic Farolino

Comment 126 2020-07-08 12:27:24 PDT

Spec has landed just FYI

Rob Buis

Comment 127 2020-07-08 15:14:07 PDT

(In reply to Dominic Farolino from comment #126) > Spec has landed just FYI I was aware of this :) BTW any news on lazy iframe loading being specified?

Dominic Farolino

Comment 128 2020-07-08 15:44:09 PDT

Yep, I just said it has landed.

Rob Buis

Comment 129 2020-07-08 23:01:33 PDT

(In reply to Dominic Farolino from comment #128) > Yep, I just said it has landed. Ah, sorry, I thought you were referring to https://github.com/whatwg/html/pull/5510 for some reason. That is great news!

Rob Buis

Comment 130 2021-10-18 07:08:54 PDT

Looks like this can be closed since both are implemented.

Simon Fraser (smfr)

Comment 131 2021-10-18 08:34:42 PDT

Both? Lazy iframe loading is implemented?

Rob Buis

Comment 132 2021-10-18 08:59:54 PDT

(In reply to Simon Fraser (smfr) from comment #131) > Both? Lazy iframe loading is implemented? I think so, that was https://bugs.webkit.org/show_bug.cgi?id=215442.

Simon Pieters (:zcorpan)

Comment 133 2022-02-02 16:21:01 PST

It seems like iframe lazy loading is still disabled by default (https://bugs.webkit.org/show_bug.cgi?id=215566). Is there a bug to enable iframe lazy loading?

Note You need to log in before you can comment on or make changes to this bug.